NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit463dde8

committed

Print wal_log_hints in the rm_desc routing of a parameter-change record.

It was an oversight in the original commit.Also note in the sample config file that changing wal_log_hints requires arestart.Michael Paquier. Backpatch to 9.4, where wal_log_hints was added.

1 parentf3d7077 commit463dde8Copy full SHA for 463dde8

File tree

2 files changed

-2

lines changed

src/backend
- access/rmgrdesc
  - xlogdesc.c
- utils/misc
  - postgresql.conf.sample

2 files changed

-2

lines changed

`‎src/backend/access/rmgrdesc/xlogdesc.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -117,12 +117,15 @@ xlog_desc(StringInfo buf, uint8 xl_info, char *rec)`
`117`	`117`	`}`
`118`	`118`	`}`
`119`	`119`
`120`		`-appendStringInfo(buf,"parameter change: max_connections=%d max_worker_processes=%d max_prepared_xacts=%d max_locks_per_xact=%d wal_level=%s",`
	`120`	`+appendStringInfo(buf,"parameter change: max_connections=%d max_worker_processes=%d "`
	`121`	`+"max_prepared_xacts=%d max_locks_per_xact=%d "`
	`122`	`+"wal_level=%s wal_log_hints=%s",`
`121`	`123`	`xlrec.MaxConnections,`
`122`	`124`	`xlrec.max_worker_processes,`
`123`	`125`	`xlrec.max_prepared_xacts,`
`124`	`126`	`xlrec.max_locks_per_xact,`
`125`		`-wal_level_str);`
	`127`	`+wal_level_str,`
	`128`	`+xlrec.wal_log_hints ?"on" :"off");`
`126`	`129`	`}`
`127`	`130`	`elseif (info==XLOG_FPW_CHANGE)`
`128`	`131`	`{`

`‎src/backend/utils/misc/postgresql.conf.sample`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,7 @@`
`186`	`186`	`# open_sync`
`187`	`187`	`#full_page_writes = on# recover from partial page writes`
`188`	`188`	`#wal_log_hints = off# also do full page writes of non-critical updates`
	`189`	`+# (change requires restart)`
`189`	`190`	`#wal_buffers = -1# min 32kB, -1 sets based on shared_buffers`
`190`	`191`	`# (change requires restart)`
`191`	`192`	`#wal_writer_delay = 200ms# 1-10000 milliseconds`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit463dde8

File tree

2 files changed

2 files changed

`‎src/backend/access/rmgrdesc/xlogdesc.c`

`‎src/backend/utils/misc/postgresql.conf.sample`

0 commit comments