NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4637a6a

committed

Silence "missing contrecord" error.

Commitdd38ff2 added a new error message "missing contrecord" whenwe fail to reassemble a record. Unfortunately that caused noisymessages to be logged by pg_waldump at end of segment, and by walsenderwhen asked to shut down on a segment boundary.Remove the new error message, so that this condition signals end-of-WAL without a message. It's arguably a reportable condition that shouldnot be silenced while performing crash recovery, but fixing that withoutintroducing noise in the other cases will require more research.Back-patch to 15.Reported-by: Tomas Vondra <tomas.vondra@enterprisedb.com>Discussion:https://postgr.es/m/6a1df56e-4656-b3ce-4b7a-a9cb41df8189%40enterprisedb.com

1 parentce5aaea commit4637a6aCopy full SHA for 4637a6a

File tree

1 file changed

-8

lines changed

src/backend/access/transam
- xlogreader.c

1 file changed

-8

lines changed

`‎src/backend/access/transam/xlogreader.c`

Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -914,15 +914,11 @@ XLogDecodeNextRecord(XLogReaderState *state, bool nonblocking)`
`914`	`914`	`state->missingContrecPtr=targetPagePtr;`
`915`	`915`
`916`	`916`	`/*`
`917`		`- * If we got here without reporting an error, report one now so that`
`918`		`- * XLogPrefetcherReadRecord() doesn't bring us back a second time and`
`919`		`- * clobber the above state. Otherwise, the existing error takes`
`920`		`- * precedence.`
	`917`	`+ * If we got here without reporting an error, make sure an error is`
	`918`	`+ * queued so that XLogPrefetcherReadRecord() doesn't bring us back a`
	`919`	`+ * second time and clobber the above state.`
`921`	`920`	`*/`
`922`		`-if (!state->errormsg_buf[0])`
`923`		`-report_invalid_record(state,`
`924`		`-"missing contrecord at %X/%X",`
`925`		`-LSN_FORMAT_ARGS(RecPtr));`
	`921`	`+state->errormsg_deferred= true;`
`926`	`922`	`}`
`927`	`923`
`928`	`924`	`if (decoded&&decoded->oversized)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4637a6a

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlogreader.c`

0 commit comments