NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit45f2c2f

committed

Need to special-case RECORD as well as UNKNOWN in plpgsql's casting logic.

This is because can_coerce_type thinks that RECORD can be cast to anycomposite type, but coerce_record_to_complex only works for inputs that areRowExprs or whole-row Vars, so we get a hard failure on a CaseTestExpr.Perhaps these corner cases ought to be fixed so that coerce_to_target_typeactually returns NULL as per its specification, rather than failing ...but for the moment an extra check here is the path of least resistance.

1 parent1345cc6 commit45f2c2fCopy full SHA for 45f2c2f

File tree

1 file changed

-4

lines changed

src/pl/plpgsql/src
- pl_exec.c

1 file changed

-4

lines changed

`‎src/pl/plpgsql/src/pl_exec.c`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5829,17 +5829,18 @@ get_cast_expression(PLpgSQL_execstate *estate,`
`5829`	`5829`	`*`
`5830`	`5830`	`* If source type is UNKNOWN, coerce_to_target_type will fail (it only`
`5831`	`5831`	`* expects to see that for Const input nodes), so don't call it; we'll`
`5832`		`- * apply CoerceViaIO instead.`
	`5832`	`+ * apply CoerceViaIO instead. Likewise, it doesn't currently work for`
	`5833`	`+ * coercing RECORD to some other type, so skip for that too.`
`5833`	`5834`	`*/`
`5834`		`-if (srctype!=UNKNOWNOID)`
	`5835`	`+if (srctype==UNKNOWNOID\|\|srctype==RECORDOID)`
	`5836`	`+cast_expr=NULL;`
	`5837`	`+else`
`5835`	`5838`	`cast_expr=coerce_to_target_type(NULL,`
`5836`	`5839`	`(Node*)placeholder,srctype,`
`5837`	`5840`	`dsttype,dsttypmod,`
`5838`	`5841`	`COERCION_ASSIGNMENT,`
`5839`	`5842`	`COERCE_IMPLICIT_CAST,`
`5840`	`5843`	`-1);`
`5841`		`-else`
`5842`		`-cast_expr=NULL;`
`5843`	`5844`
`5844`	`5845`	`/*`
`5845`	`5846`	`* If there's no cast path according to the parser, fall back to using an`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit45f2c2f

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/pl_exec.c`

0 commit comments