Commit45cc0e9

committed

plpgsql RAISE statement was careless about the possibility of a NULL

field value being displayed; produced coredump instead of the expected<NULL> display.

1 parentf106779 commit45cc0e9Copy full SHA for 45cc0e9

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* procedural language`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $Header: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.20 2000/04/12 17:17:19 momjian Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.21 2000/04/28 00:12:44 tgl Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -1587,6 +1587,8 @@ exec_stmt_raise(PLpgSQL_execstate * estate, PLpgSQL_stmt_raise * stmt)`
`1587`	`1587`	`if (fno==SPI_ERROR_NOATTRIBUTE)`
`1588`	`1588`	`elog(ERROR,"record %s has no field %s",rec->refname,recfield->fieldname);`
`1589`	`1589`	`extval=SPI_getvalue(rec->tup,rec->tupdesc,fno);`
	`1590`	`+if (extval==NULL)`
	`1591`	`+extval="<NULL>";`
`1590`	`1592`	`}`
`1591`	`1593`	`plpgsql_dstring_append(&ds,extval);`
`1592`	`1594`	`break;`

Comments

(0)