NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit458857c

committed

Throw a useful error message if an extension script file is fed to psql.

We have seen one too many reports of people trying to use 9.1 extensionfiles in the old-fashioned way of sourcing them in psql. Not only doesthat usually not work (due to failure to substitute for MODULE_PATHNAMEand/or @extschema@), but if it did work they'd get a collection of looseobjects not an extension. To prevent this, insert an \echo ... \quitline that prints a suitable error message into each extension script file,and teach commands/extension.c to ignore lines starting with \echo.That should not only prevent any adverse consequences of loading a scriptfile the wrong way, but make it crystal clear to users that they need todo it differently now.Tom Lane, following an idea of Andrew Dunstan's. Back-patch into 9.1... there is not going to be much value in this if we wait till 9.2.

1 parente0d2735 commit458857cCopy full SHA for 458857c

File tree

78 files changed

+274

-17

lines changed

contrib
- adminpack
  - adminpack--1.0.sql
- btree_gin
  - btree_gin--1.0.sql
  - btree_gin--unpackaged--1.0.sql
- btree_gist
  - btree_gist--1.0.sql
  - btree_gist--unpackaged--1.0.sql
- chkpass
  - chkpass--1.0.sql
  - chkpass--unpackaged--1.0.sql
- citext
  - citext--1.0.sql
  - citext--unpackaged--1.0.sql
- cube
  - cube--1.0.sql
  - cube--unpackaged--1.0.sql
- dblink
  - dblink--1.0.sql
  - dblink--unpackaged--1.0.sql
- dict_int
  - dict_int--1.0.sql
  - dict_int--unpackaged--1.0.sql
- dict_xsyn
  - dict_xsyn--1.0.sql
  - dict_xsyn--unpackaged--1.0.sql
- earthdistance
  - earthdistance--1.0.sql
  - earthdistance--unpackaged--1.0.sql
- file_fdw
  - file_fdw--1.0.sql
- fuzzystrmatch
  - fuzzystrmatch--1.0.sql
  - fuzzystrmatch--unpackaged--1.0.sql
- hstore
  - hstore--1.0.sql
  - hstore--unpackaged--1.0.sql
- intagg
  - intagg--1.0.sql
  - intagg--unpackaged--1.0.sql
- intarray
  - intarray--1.0.sql
  - intarray--unpackaged--1.0.sql
- isn
  - isn--1.0.sql
  - isn--unpackaged--1.0.sql
- lo
  - lo--1.0.sql
  - lo--unpackaged--1.0.sql
- ltree
  - ltree--1.0.sql
  - ltree--unpackaged--1.0.sql
- pageinspect
  - pageinspect--1.0.sql
  - pageinspect--unpackaged--1.0.sql
- pg_buffercache
  - pg_buffercache--1.0.sql
  - pg_buffercache--unpackaged--1.0.sql
- pg_freespacemap
  - pg_freespacemap--1.0.sql
  - pg_freespacemap--unpackaged--1.0.sql
- pg_stat_statements
  - pg_stat_statements--1.0.sql
  - pg_stat_statements--unpackaged--1.0.sql
- pg_trgm
  - pg_trgm--1.0.sql
  - pg_trgm--unpackaged--1.0.sql
- pgcrypto
  - pgcrypto--1.0.sql
  - pgcrypto--unpackaged--1.0.sql
- pgrowlocks
  - pgrowlocks--1.0.sql
  - pgrowlocks--unpackaged--1.0.sql
- pgstattuple
  - pgstattuple--1.0.sql
  - pgstattuple--unpackaged--1.0.sql
- seg
  - seg--1.0.sql
  - seg--unpackaged--1.0.sql
- spi
  - autoinc--1.0.sql
  - autoinc--unpackaged--1.0.sql
  - insert_username--1.0.sql
  - insert_username--unpackaged--1.0.sql
  - moddatetime--1.0.sql
  - moddatetime--unpackaged--1.0.sql
  - refint--1.0.sql
  - refint--unpackaged--1.0.sql
  - timetravel--1.0.sql
  - timetravel--unpackaged--1.0.sql
- sslinfo
  - sslinfo--1.0.sql
  - sslinfo--unpackaged--1.0.sql
- tablefunc
  - tablefunc--1.0.sql
  - tablefunc--unpackaged--1.0.sql
- test_parser
  - test_parser--1.0.sql
  - test_parser--unpackaged--1.0.sql
- tsearch2
  - tsearch2--1.0.sql
  - tsearch2--unpackaged--1.0.sql
- unaccent
  - unaccent--1.0.sql
  - unaccent--unpackaged--1.0.sql
- uuid-ossp
  - uuid-ossp--1.0.sql
  - uuid-ossp--unpackaged--1.0.sql
- xml2
  - xml2--1.0.sql
  - xml2--unpackaged--1.0.sql
doc/src/sgml
- extend.sgml
src/backend/commands
- extension.c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+274

-17

lines changed