Commit4572d59

committed

Improve style of two code paths

In execGrouping.c, execTuplesMatchPrepare() was doing a memoryallocation that was not necessary when the number of columns was 0.In foreign.c, pg_options_to_table() was assigning twice a variable tothe same value.Author: Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAqup0agbSzMjSLSTn=OANyCzxENF1+HrSYnr3WyZib7=Q@mail.gmail.com

1 parenta9ed7d9 commit4572d59Copy full SHA for 4572d59

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -62,13 +62,15 @@ execTuplesMatchPrepare(TupleDesc desc,`
`62`	`62`	`constOid*collations,`
`63`	`63`	`PlanState*parent)`
`64`	`64`	`{`
`65`		`-OideqFunctions= (Oid)palloc(numCols*sizeof(Oid));`
	`65`	`+Oid*eqFunctions;`
`66`	`66`	`inti;`
`67`	`67`	`ExprState*expr;`
`68`	`68`
`69`	`69`	`if (numCols==0)`
`70`	`70`	`returnNULL;`
`71`	`71`
	`72`	`+eqFunctions= (Oid)palloc(numColssizeof(Oid));`
	`73`	`+`
`72`	`74`	`/* lookup equality functions */`
`73`	`75`	`for (i=0;i<numCols;i++)`
`74`	`76`	`eqFunctions[i]=get_opcode(eqOperators[i]);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -524,7 +524,7 @@ pg_options_to_table(PG_FUNCTION_ARGS)`
`524`	`524`	`Datumarray=PG_GETARG_DATUM(0);`
`525`	`525`	`ListCell*cell;`
`526`	`526`	`List*options;`
`527`		`-ReturnSetInforsinfo= (ReturnSetInfo)fcinfo->resultinfo;`
	`527`	`+ReturnSetInfo*rsinfo;`
`528`	`528`
`529`	`529`	`options=untransformRelOptions(array);`
`530`	`530`	`rsinfo= (ReturnSetInfo*)fcinfo->resultinfo;`

Comments

(0)