NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit456ff08

committed

Fix some problems with patch to fsync the data directory.

pg_win32_is_junction() was a typo for pgwin32_is_junction(). open()was used not only in a two-argument form, which breaks on Windows,but also where BasicOpenFile() should have been used.Per reports from Andrew Dunstan and David Rowley.

1 parentc0574cd commit456ff08Copy full SHA for 456ff08

File tree

1 file changed

-2

lines changed

src/backend/storage/file
- fd.c

1 file changed

-2

lines changed

`‎src/backend/storage/file/fd.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2450,7 +2450,7 @@ pre_sync_fname(char *fname, bool isdir)`
`2450`	`2450`	`{`
`2451`	`2451`	`intfd;`
`2452`	`2452`
`2453`		`-fd=open(fname,O_RDONLY \|PG_BINARY);`
	`2453`	`+fd=BasicOpenFile(fname,O_RDONLY \|PG_BINARY,0);`
`2454`	`2454`
`2455`	`2455`	`/*`
`2456`	`2456`	`* Some OSs don't allow us to open directories at all (Windows returns`
`@@ -2509,7 +2509,7 @@ walkdir(char path, void (action) (char *fname, bool isdir))`
`2509`	`2509`	`#ifndefWIN32`
`2510`	`2510`	`elseif (S_ISLNK(fst.st_mode))`
`2511`	`2511`	`#else`
`2512`		`-elseif (pg_win32_is_junction(subpath))`
	`2512`	`+elseif (pgwin32_is_junction(subpath))`
`2513`	`2513`	`#endif`
`2514`	`2514`	`{`
`2515`	`2515`	`#if defined(HAVE_READLINK)\|\| defined(WIN32)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit456ff08

File tree

1 file changed

1 file changed

`‎src/backend/storage/file/fd.c`

0 commit comments