NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit449d0a8

Etsuro Fujita

committed

postgres_fdw: Fix test for cached costs in estimate_path_cost_size().

estimate_path_cost_size() failed to re-use cached costs when the cachedstartup/total cost was 0, so it calculated the costs redundantly.This is an oversight in commitaa09cd2; but apply the patch to HEADonly because there are no reports of actual trouble from that.Author: Etsuro FujitaDiscussion:https://postgr.es/m/5C4AF3F3.4060409%40lab.ntt.co.jp

1 parente0c2933 commit449d0a8Copy full SHA for 449d0a8

File tree

1 file changed

-1

lines changed

contrib/postgres_fdw
- postgres_fdw.c

1 file changed

-1

lines changed

`‎contrib/postgres_fdw/postgres_fdw.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2625,7 +2625,7 @@ estimate_path_cost_size(PlannerInfo *root,`
`2625`	`2625`	`* bare scan each time. Instead, use the costs if we have cached them`
`2626`	`2626`	`* already.`
`2627`	`2627`	`*/`
`2628`		`-if (fpinfo->rel_startup_cost>0&&fpinfo->rel_total_cost>0)`
	`2628`	`+if (fpinfo->rel_startup_cost >=0&&fpinfo->rel_total_cost >=0)`
`2629`	`2629`	`{`
`2630`	`2630`	`startup_cost=fpinfo->rel_startup_cost;`
`2631`	`2631`	`run_cost=fpinfo->rel_total_cost-fpinfo->rel_startup_cost;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit449d0a8

File tree

1 file changed

1 file changed

`‎contrib/postgres_fdw/postgres_fdw.c`

0 commit comments