NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit443a8e4

committed

Add some more use of Page/PageData rather than char *

Discussion:https://www.postgresql.org/message-id/flat/692ee0da-49da-4d32-8dca-da224cc2800e@eisentraut.org

1 parent4f4a1d8 commit443a8e4Copy full SHA for 443a8e4

File tree

2 files changed

+12

-11

lines changed

src
- backend/access/transam
  - xloginsert.c
- include/access
  - xloginsert.h

2 files changed

+12

-11

lines changed

`‎src/backend/access/transam/xloginsert.c`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ typedef struct`
`72`	`72`	`RelFileLocatorrlocator;/* identifies the relation and block */`
`73`	`73`	`ForkNumberforkno;`
`74`	`74`	`BlockNumberblock;`
`75`		`-constcharpage;/ page content */`
	`75`	`+constPageDatapage;/ page content */`
`76`	`76`	`uint32rdata_len;/* total length of data in rdata chain */`
`77`	`77`	`XLogRecDatardata_head;/ head of the chain of data registered with`
`78`	`78`	`* this block */`
`@@ -138,8 +138,8 @@ static XLogRecData *XLogRecordAssemble(RmgrId rmid, uint8 info,`
`138`	`138`	`XLogRecPtrRedoRecPtr,booldoPageWrites,`
`139`	`139`	`XLogRecPtrfpw_lsn,intnum_fpi,`
`140`	`140`	`bool*topxid_included);`
`141`		`-staticboolXLogCompressBackupBlock(constchar*page,uint16hole_offset,`
`142`		`-uint16hole_length,chardest,uint16dlen);`
	`141`	`+staticboolXLogCompressBackupBlock(constPageData*page,uint16hole_offset,`
	`142`	`+uint16hole_length,voiddest,uint16dlen);`
`143`	`143`
`144`	`144`	`/*`
`145`	`145`	`* Begin constructing a WAL record. This must be called before the`
`@@ -307,7 +307,7 @@ XLogRegisterBuffer(uint8 block_id, Buffer buffer, uint8 flags)`
`307`	`307`	`*/`
`308`	`308`	`void`
`309`	`309`	`XLogRegisterBlock(uint8block_id,RelFileLocator*rlocator,ForkNumberforknum,`
`310`		`-BlockNumberblknum,constchar*page,uint8flags)`
	`310`	`+BlockNumberblknum,constPageData*page,uint8flags)`
`311`	`311`	`{`
`312`	`312`	`registered_buffer*regbuf;`
`313`	`313`
`@@ -648,7 +648,7 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,`
`648`	`648`
`649`	`649`	`if (include_image)`
`650`	`650`	`{`
`651`		`-constchar*page=regbuf->page;`
	`651`	`+constPageData*page=regbuf->page;`
`652`	`652`	`uint16compressed_len=0;`
`653`	`653`
`654`	`654`	`/*`
`@@ -941,13 +941,13 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,`
`941`	`941`	`* the length of compressed block image.`
`942`	`942`	`*/`
`943`	`943`	`staticbool`
`944`		`-XLogCompressBackupBlock(constchar*page,uint16hole_offset,uint16hole_length,`
`945`		`-chardest,uint16dlen)`
	`944`	`+XLogCompressBackupBlock(constPageData*page,uint16hole_offset,uint16hole_length,`
	`945`	`+voiddest,uint16dlen)`
`946`	`946`	`{`
`947`	`947`	`int32orig_len=BLCKSZ-hole_length;`
`948`	`948`	`int32len=-1;`
`949`	`949`	`int32extra_bytes=0;`
`950`		`-constchar*source;`
	`950`	`+constvoid*source;`
`951`	`951`	`PGAlignedBlocktmp;`
`952`	`952`
`953`	`953`	`if (hole_length!=0)`

`‎src/include/access/xloginsert.h`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`#include"access/xlogdefs.h"`
`16`	`16`	`#include"storage/block.h"`
`17`	`17`	`#include"storage/buf.h"`
	`18`	`+#include"storage/bufpage.h"`
`18`	`19`	`#include"storage/relfilelocator.h"`
`19`	`20`	`#include"utils/relcache.h"`
`20`	`21`
`@@ -47,16 +48,16 @@ extern void XLogEnsureRecordSpace(int max_block_id, int ndatas);`
`47`	`48`	`externvoidXLogRegisterData(constchar*data,uint32len);`
`48`	`49`	`externvoidXLogRegisterBuffer(uint8block_id,Bufferbuffer,uint8flags);`
`49`	`50`	`externvoidXLogRegisterBlock(uint8block_id,RelFileLocator*rlocator,`
`50`		`-ForkNumberforknum,BlockNumberblknum,constchar*page,`
	`51`	`+ForkNumberforknum,BlockNumberblknum,constPageData*page,`
`51`	`52`	`uint8flags);`
`52`	`53`	`externvoidXLogRegisterBufData(uint8block_id,constchar*data,uint32len);`
`53`	`54`	`externvoidXLogResetInsertion(void);`
`54`	`55`	`externboolXLogCheckBufferNeedsBackup(Bufferbuffer);`
`55`	`56`
`56`	`57`	`externXLogRecPtrlog_newpage(RelFileLocator*rlocator,ForkNumberforknum,`
`57`		`-BlockNumberblkno,char*page,boolpage_std);`
	`58`	`+BlockNumberblkno,Pagepage,boolpage_std);`
`58`	`59`	`externvoidlog_newpages(RelFileLocator*rlocator,ForkNumberforknum,intnum_pages,`
`59`		`-BlockNumberblknos,char*pages,boolpage_std);`
	`60`	`+BlockNumberblknos,Pagepages,boolpage_std);`
`60`	`61`	`externXLogRecPtrlog_newpage_buffer(Bufferbuffer,boolpage_std);`
`61`	`62`	`externvoidlog_newpage_range(Relationrel,ForkNumberforknum,`
`62`	`63`	`BlockNumberstartblk,BlockNumberendblk,boolpage_std);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit443a8e4

File tree

2 files changed

2 files changed

`‎src/backend/access/transam/xloginsert.c`

`‎src/include/access/xloginsert.h`

0 commit comments