NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4433c6e

committed

During heap rebuild, lock any TOAST index until end of transaction.

swap_relation_files() calls toast_get_valid_index() to find and lockthis index, just before swapping with the rebuilt TOAST index. Thelatter function releases the lock before returning. Potential formischief is low; a concurrent session can issue ALTER INDEX ... SET(fillfactor = ...), which is not alarming. Nonetheless, changingpg_class.relfilenode without a lock is unconventional. Back-patch to9.5 (all supported versions), because another fix needs this.Discussion:https://postgr.es/m/20191226001521.GA1772687@rfd.leadboat.com

1 parent03e99a6 commit4433c6eCopy full SHA for 4433c6e

File tree

2 files changed

-3

lines changed

src/backend
- access/heap
  - tuptoaster.c
- commands
  - cluster.c

2 files changed

-3

lines changed

`‎src/backend/access/heap/tuptoaster.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1445,8 +1445,8 @@ toast_get_valid_index(Oid toastoid, LOCKMODE lock)`
`1445`	`1445`	`validIndexOid=RelationGetRelid(toastidxs[validIndex]);`
`1446`	`1446`
`1447`	`1447`	`/* Close the toast relation and all its indexes */`
`1448`		`-toast_close_indexes(toastidxs,num_indexes,lock);`
`1449`		`-heap_close(toastrel,lock);`
	`1448`	`+toast_close_indexes(toastidxs,num_indexes,NoLock);`
	`1449`	`+heap_close(toastrel,NoLock);`
`1450`	`1450`
`1451`	`1451`	`returnvalidIndexOid;`
`1452`	`1452`	`}`

`‎src/backend/commands/cluster.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1652,7 +1652,7 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap,`
`1652`	`1652`
`1653`	`1653`	`/* Get the associated valid index to be renamed */`
`1654`	`1654`	`toastidx=toast_get_valid_index(newrel->rd_rel->reltoastrelid,`
`1655`		`-AccessShareLock);`
	`1655`	`+NoLock);`
`1656`	`1656`
`1657`	`1657`	`/* rename the toast table ... */`
`1658`	`1658`	`snprintf(NewToastName,NAMEDATALEN,"pg_toast_%u",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4433c6e

File tree

2 files changed

2 files changed

`‎src/backend/access/heap/tuptoaster.c`

`‎src/backend/commands/cluster.c`

0 commit comments