NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit43cd7ab

committed

Fix thinko in comment

The listed numbers disagreed with the ones being used in the symbols;but instead of just fixing the numbers in the comment, use the symbolicname instead, which seems clearer.This has been wrong all along, so apply back to 9.5 where BRIN wasintroduced.Reported-by: Tomas VondraDiscussion:https://postgr.es/m/5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com

1 parent356f85f commit43cd7abCopy full SHA for 43cd7ab

File tree

1 file changed

-4

lines changed

src/backend/access/brin
- brin_inclusion.c

1 file changed

-4

lines changed

`‎src/backend/access/brin/brin_inclusion.c`

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,10 +58,14 @@`
`58`	`58`	`/*-`
`59`	`59`	`* The values stored in the bv_values arrays correspond to:`
`60`	`60`	`*`
`61`		`- * 0 - the union of the values in the block range`
`62`		`- * 1 - whether an empty value is present in any tuple in the block range`
`63`		`- * 2 - whether the values in the block range cannot be merged (e.g. an IPv6`
`64`		`- * address amidst IPv4 addresses).`
	`61`	`+ * INCLUSION_UNION`
	`62`	`+ *the union of the values in the block range`
	`63`	`+ * INCLUSION_UNMERGEABLE`
	`64`	`+ *whether the values in the block range cannot be merged`
	`65`	`+ *(e.g. an IPv6 address amidst IPv4 addresses)`
	`66`	`+ * INCLUSION_CONTAINS_EMPTY`
	`67`	`+ *whether an empty value is present in any tuple`
	`68`	`+ *in the block range`
`65`	`69`	`*/`
`66`	`70`	`#defineINCLUSION_UNION0`
`67`	`71`	`#defineINCLUSION_UNMERGEABLE1`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit43cd7ab

File tree

1 file changed

1 file changed

`‎src/backend/access/brin/brin_inclusion.c`

0 commit comments