NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit43b55ec

committed

Fix uninitialized memory bug

Have interested callers of find_inheritance_children set thedetached_exist value to false prior to calling it, so that that routineonly has to set it true in the rare cases where it is necessary. Don'ttouch it otherwise.Per buildfarm member thorntail (which reported a UBSan failure here).

1 parent84f15cc commit43b55ecCopy full SHA for 43b55ec

File tree

2 files changed

-4

lines changed

src/backend
- catalog
  - pg_inherits.c
- partitioning
  - partdesc.c

2 files changed

-4

lines changed

`‎src/backend/catalog/pg_inherits.c`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ typedef struct SeenRelsEntry`
`53`	`53`	`* against possible DROPs of child relations.`
`54`	`54`	`*`
`55`	`55`	`* If a partition's pg_inherits row is marked "detach pending",`
`56`		`- * *detached_exist (if not null) is set true, otherwise it is set false.`
	`56`	`+ * *detached_exist (if not null) is set true.`
`57`	`57`	`*`
`58`	`58`	`* If omit_detached is true and there is an active snapshot (not the same as`
`59`	`59`	`* the catalog snapshot used to scan pg_inherits!) and a pg_inherits tuple`
`@@ -84,9 +84,6 @@ find_inheritance_children(Oid parentrelId, bool omit_detached,`
`84`	`84`	`if (!has_subclass(parentrelId))`
`85`	`85`	`returnNIL;`
`86`	`86`
`87`		`-if (detached_exist)`
`88`		`-*detached_exist= false;`
`89`		`-`
`90`	`87`	`/*`
`91`	`88`	`* Scan pg_inherits and build a working array of subclass OIDs.`
`92`	`89`	`*/`

`‎src/backend/partitioning/partdesc.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ RelationBuildPartitionDesc(Relation rel, bool omit_detached)`
`131`	`131`	`* concurrently, whatever this function returns will be accurate as of`
`132`	`132`	`* some well-defined point in time.`
`133`	`133`	`*/`
	`134`	`+detached_exist= false;`
`134`	`135`	`inhoids=find_inheritance_children(RelationGetRelid(rel),omit_detached,`
`135`	`136`	`NoLock,&detached_exist);`
`136`	`137`	`nparts=list_length(inhoids);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit43b55ec

File tree

2 files changed

2 files changed

`‎src/backend/catalog/pg_inherits.c`

`‎src/backend/partitioning/partdesc.c`

0 commit comments