Commit43aa40e

committed

In pg_upgrade, add C comment about why we don't try to do shared file

writes for logging.

1 parenta9f0dbc commit43aa40eCopy full SHA for 43aa40e

File tree

-0

lines changed

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -207,6 +207,10 @@ typedef struct`
`207`	`207`	`* because it is being used by another process." so we have to send all`
`208`	`208`	`* other output to 'nul'. Therefore, we set this to DEVNULL on Win32, and`
`209`	`209`	`* it equals 'filename' on all other platforms.`
	`210`	`+ *`
	`211`	`+ * We could use the Windows pgwin32_open() flags to allow shared file`
	`212`	`+ * writes but is unclear how all other tools would use those flags, so`
	`213`	`+ * we just avoid it and log a little less on Windows.`
`210`	`214`	`*/`
`211`	`215`	`char*filename2;`
`212`	`216`	`FILEfd;/ log FILE */`

Comments

(0)