NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit438fc4a

committed

Fix bug in WAL replay of COMMIT_TS_SETTS record.

Previously the WAL replay of COMMIT_TS_SETTS record calledTransactionTreeSetCommitTsData() with the argument write_xlog=true,which generated and wrote new COMMIT_TS_SETTS record.This should not be acceptable because it's during recovery.This commit fixes the WAL replay of COMMIT_TS_SETTS recordso that it calls TransactionTreeSetCommitTsData() with write_xlog=falseand doesn't generate new WAL during recovery.Back-patch to all supported branches.Reported-by: lx zou <zoulx1982@163.com>Author: Fujii MasaoReviewed-by: Alvaro HerreraDiscussion:https://postgr.es/m/16931-620d0f2fdc6108f1@postgresql.org

1 parentdf93844 commit438fc4aCopy full SHA for 438fc4a

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- commit_ts.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/commit_ts.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1074,7 +1074,7 @@ commit_ts_redo(XLogReaderState *record)`
`1074`	`1074`	`subxids=NULL;`
`1075`	`1075`
`1076`	`1076`	`TransactionTreeSetCommitTsData(setts->mainxid,nsubxids,subxids,`
`1077`		`-setts->timestamp,setts->nodeid,true);`
	`1077`	`+setts->timestamp,setts->nodeid,false);`
`1078`	`1078`	`if (subxids)`
`1079`	`1079`	`pfree(subxids);`
`1080`	`1080`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit438fc4a

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/commit_ts.c`

0 commit comments