NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit433e65c

committed

Restore psql's SIGPIPE setting if popen() fails.

Ancient oversight in PageOutput(): if popen() fails, we'd better resetthe SIGPIPE handler before returning stdout, because ClosePager() won't.Noticed while fixing the empty-PAGER issue.

1 parent82eb5c5 commit433e65cCopy full SHA for 433e65c

File tree

1 file changed

-0

lines changed

src/bin/psql
- print.c

1 file changed

-0

lines changed

`‎src/bin/psql/print.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2217,6 +2217,10 @@ PageOutput(int lines, unsigned short int pager)`
`2217`	`2217`	`pagerpipe=popen(pagerprog,"w");`
`2218`	`2218`	`if (pagerpipe)`
`2219`	`2219`	`returnpagerpipe;`
	`2220`	`+/* if popen fails, silently proceed without pager */`
	`2221`	`+#ifndefWIN32`
	`2222`	`+pqsignal(SIGPIPE,SIG_DFL);`
	`2223`	`+#endif`
`2220`	`2224`	`#ifdefTIOCGWINSZ`
`2221`	`2225`	`}`
`2222`	`2226`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit433e65c

File tree

1 file changed

1 file changed

`‎src/bin/psql/print.c`

0 commit comments