NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4323142

committed

Feed ObjectAddress to event triggers for ALTER TABLE ATTACH/DETACH

These flavors of ALTER TABLE were already shaped to report theObjectAddress of the partition attached or detached, but this data wasnot added to what is collected for event triggers. The tests oftest_ddl_deparse are updated to show the modification in the datareported.Author: Hou ZhijieReviewed-by: Álvaro Herrera, Amit Kapila, Hayato Kuroda, Michael PaquierDiscussion:https://postgr.es/m/OS0PR01MB571626984BD099DADF53F38394899@OS0PR01MB5716.jpnprd01.prod.outlook.com

1 parent07ff701 commit4323142Copy full SHA for 4323142

File tree

2 files changed

+10

-10

lines changed

src
- backend/commands
  - tablecmds.c
- test/modules/test_ddl_deparse/expected
  - alter_table.out

2 files changed

+10

-10

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -5202,24 +5202,24 @@ ATExecCmd(List *wqueue, AlteredTableInfo tab,`
`5202`	`5202`	`cur_pass, context);`
`5203`	`5203`	`Assert(cmd != NULL);`
`5204`	`5204`	`if (rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)`
`5205`		`-ATExecAttachPartition(wqueue, rel, (PartitionCmd *) cmd->def,`
`5206`		`-context);`
	`5205`	`+address =ATExecAttachPartition(wqueue, rel, (PartitionCmd *) cmd->def,`
	`5206`	`+context);`
`5207`	`5207`	`else`
`5208`		`-ATExecAttachPartitionIdx(wqueue, rel,`
`5209`		`- ((PartitionCmd *) cmd->def)->name);`
	`5208`	`+address =ATExecAttachPartitionIdx(wqueue, rel,`
	`5209`	`+ ((PartitionCmd *) cmd->def)->name);`
`5210`	`5210`	`break;`
`5211`	`5211`	`case AT_DetachPartition:`
`5212`	`5212`	`cmd = ATParseTransformCmd(wqueue, tab, rel, cmd, false, lockmode,`
`5213`	`5213`	`cur_pass, context);`
`5214`	`5214`	`Assert(cmd != NULL);`
`5215`	`5215`	`/* ATPrepCmd ensures it must be a table */`
`5216`	`5216`	`Assert(rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE);`
`5217`		`-ATExecDetachPartition(wqueue, tab, rel,`
`5218`		`-((PartitionCmd *) cmd->def)->name,`
`5219`		`-((PartitionCmd *) cmd->def)->concurrent);`
	`5217`	`+address =ATExecDetachPartition(wqueue, tab, rel,`
	`5218`	`+((PartitionCmd *) cmd->def)->name,`
	`5219`	`+((PartitionCmd *) cmd->def)->concurrent);`
`5220`	`5220`	`break;`
`5221`	`5221`	`case AT_DetachPartitionFinalize:`
`5222`		`-ATExecDetachPartitionFinalize(rel, ((PartitionCmd *) cmd->def)->name);`
	`5222`	`+address =ATExecDetachPartitionFinalize(rel, ((PartitionCmd *) cmd->def)->name);`
`5223`	`5223`	`break;`
`5224`	`5224`	`default:/* oops */`
`5225`	`5225`	`elog(ERROR, "unrecognized alter table type: %d",`

`‎src/test/modules/test_ddl_deparse/expected/alter_table.out`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,10 +50,10 @@ CREATE TABLE part2 (a int);`
`50`	`50`	`NOTICE: DDL test: type simple, tag CREATE TABLE`
`51`	`51`	`ALTER TABLE part ATTACH PARTITION part2 FOR VALUES FROM (101) to (200);`
`52`	`52`	`NOTICE: DDL test: type alter table, tag ALTER TABLE`
`53`		`-NOTICE: subcommand: type ATTACH PARTITION desc<NULL>`
	`53`	`+NOTICE: subcommand: type ATTACH PARTITION desctable part2`
`54`	`54`	`ALTER TABLE part DETACH PARTITION part2;`
`55`	`55`	`NOTICE: DDL test: type alter table, tag ALTER TABLE`
`56`		`-NOTICE: subcommand: type DETACH PARTITION desc<NULL>`
	`56`	`+NOTICE: subcommand: type DETACH PARTITION desctable part2`
`57`	`57`	`DROP TABLE part2;`
`58`	`58`	`ALTER TABLE part ADD PRIMARY KEY (a);`
`59`	`59`	`NOTICE: DDL test: type alter table, tag ALTER TABLE`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4323142

File tree

2 files changed

2 files changed

`‎src/backend/commands/tablecmds.c`

`‎src/test/modules/test_ddl_deparse/expected/alter_table.out`

0 commit comments