NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit42eae25

committed

Update comments about index parallel builds

Commitb437571 allowed parallel builds for BRIN, but left behindtwo comments claiming only btree indexes support parallel builds.Reported by Egor Rogov, along with similar issues in SGML docs.Backpatch to 17, where parallel builds for BRIN were introduced.Reported-by: Egor RogovBackpatch-through: 17Discussion:https://postgr.es/m/114e2d5d-125e-07d8-94aa-5ad175fb7443@postgrespro.ru

1 parent88baa27 commit42eae25Copy full SHA for 42eae25

File tree

2 files changed

-2

lines changed

src/backend
- catalog
  - index.c
- optimizer/plan
  - planner.c

2 files changed

-2

lines changed

`‎src/backend/catalog/index.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2958,7 +2958,7 @@ index_build(Relation heapRelation,`
`2958`	`2958`
`2959`	`2959`	`/*`
`2960`	`2960`	`* Determine worker process details for parallel CREATE INDEX. Currently,`
`2961`		`- * only btreehas support for parallel builds.`
	`2961`	`+ * only btreeand BRIN have support for parallel builds.`
`2962`	`2962`	`*`
`2963`	`2963`	`* Note that planner considers parallel safety for us.`
`2964`	`2964`	`*/`

`‎src/backend/optimizer/plan/planner.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6768,7 +6768,8 @@ plan_cluster_use_sort(Oid tableOid, Oid indexOid)`
`6768`	`6768`	`*CREATE INDEX should request for use`
`6769`	`6769`	`*`
`6770`	`6770`	`* tableOid is the table on which the index is to be built. indexOid is the`
`6771`		`- * OID of an index to be created or reindexed (which must be a btree index).`
	`6771`	`+ * OID of an index to be created or reindexed (which must be an index with`
	`6772`	`+ * support for parallel builds - currently btree or BRIN).`
`6772`	`6773`	`*`
`6773`	`6774`	`* Return value is the number of parallel worker processes to request. It`
`6774`	`6775`	`* may be unsafe to proceed if this is 0. Note that this does not include the`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit42eae25

File tree

2 files changed

2 files changed

`‎src/backend/catalog/index.c`

`‎src/backend/optimizer/plan/planner.c`

0 commit comments