NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit42ad25f

committed

init_fcache was being careless about using SearchSysCacheTuple result

over multiple lookups --- it should use SearchSysCacheTupleCopy instead.This accounts for rare failures like 'init_fcache: null probin for procedure 481'when running concurrently with a VACUUM.

1 parente57e991 commit42ad25fCopy full SHA for 42ad25f

File tree

1 file changed

-4

lines changed

src/backend/utils/cache
- fcache.c

1 file changed

-4

lines changed

`‎src/backend/utils/cache/fcache.c`

Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,12 +8,13 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/fcache.c,v 1.31 2000/05/28 17:56:06 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/fcache.c,v 1.32 2000/06/06 17:44:25 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`15`	`15`	`#include"postgres.h"`
`16`	`16`
	`17`	`+#include"access/heapam.h"`
`17`	`18`	`#include"catalog/pg_language.h"`
`18`	`19`	`#include"catalog/pg_proc.h"`
`19`	`20`	`#include"catalog/pg_type.h"`
`@@ -77,11 +78,13 @@ init_fcache(Oid foid,`
`77`	`78`
`78`	`79`	`/* ----------------`
`79`	`80`	`* get the procedure tuple corresponding to the given functionOid`
	`81`	`+ *`
	`82`	`+ * NB: use SearchSysCacheTupleCopy to ensure tuple lives long enough`
`80`	`83`	`* ----------------`
`81`	`84`	`*/`
`82`		`-procedureTuple=SearchSysCacheTuple(PROCOID,`
`83`		`-ObjectIdGetDatum(foid),`
`84`		`-0,0,0);`
	`85`	`+procedureTuple=SearchSysCacheTupleCopy(PROCOID,`
	`86`	`+ObjectIdGetDatum(foid),`
	`87`	`+0,0,0);`
`85`	`88`
`86`	`89`	`if (!HeapTupleIsValid(procedureTuple))`
`87`	`90`	`elog(ERROR,"init_fcache: Cache lookup failed for procedure %u",`
`@@ -245,6 +248,8 @@ init_fcache(Oid foid,`
`245`	`248`	`else`
`246`	`249`	`retval->func.fn_addr= (PGFunction)NULL;`
`247`	`250`
	`251`	`+heap_freetuple(procedureTuple);`
	`252`	`+`
`248`	`253`	`returnretval;`
`249`	`254`	`}`
`250`	`255`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit42ad25f

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/fcache.c`

0 commit comments