forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit42510c0
committed
Rename libpq trace internal functions
libpq's pqTraceOutputMessage() used to look like this: case 'Z': /* Ready For Query */ pqTraceOutputZ(conn->Pfdebug, message, &logCursor); break;Commitf4b54e1 introduced macros for protocol characters, so nowit looks like this: case PqMsg_ReadyForQuery: pqTraceOutputZ(conn->Pfdebug, message, &logCursor); break;But this introduced a disconnect between the symbol in the switch caseand the function name to be called, so this made the manageability ofthis file a bit worse.This patch changes the function names to match, so now it looks likethis: case PqMsg_ReadyForQuery: pqTraceOutput_ReadyForQuery(conn->Pfdebug, message, &logCursor); break;(This also improves the readability of the file in general, since somefunction names like "pqTraceOutputt" were a little hard to readaccurately.)Some protocol characters have different meanings to and from theserver. The old code structure had a common function for both, forexample, pqTraceOutputD(). The new structure splits this up intoseparate ones to match the protocol message name, likepqTraceOutput_Describe() and pqTraceOutput_DataRow().Reviewed-by: Yugo NAGATA <nagata@sraoss.co.jp>Discussion:https://www.postgresql.org/message-id/flat/575e4f9d-acfe-45e3-b7f1-7e32c579090e%40eisentraut.org1 parent13daa33 commit42510c0
1 file changed
+100
-108
lines changed0 commit comments
Comments
(0)