NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit423e121

committed

Accept pg_upgraded tuples during multixact freezing

The new MultiXact freezing routines introduced by commit8e9a16aneglected to consider tuples that came from a pg_upgrade'd database; avacuum run that tried to freeze such tuples would die with an error suchasERROR: MultiXactId 11415437 does no longer exist -- apparent wraparoundTo fix, ensure that GetMultiXactIdMembers is allowed to return emptymultis when the infomask bits are right, as is done in other callsites.Per trouble report from F-Secure.In passing, fix a copy&paste bug reported by Andrey Karpov from VIVA64from their PVS-Studio static checked, that instead of setting relminmxidto Invalid, we were setting relfrozenxid twice. Not an importantmistake because that code branch is about relations for which we don'tuse the frozenxid/minmxid values at all in the first place, but seems towarrants a fix nonetheless.

1 parentfaab7a9 commit423e121Copy full SHA for 423e121

File tree

2 files changed

-3

lines changed

src/backend
- access/heap
  - heapam.c
- catalog
  - heap.c

2 files changed

-3

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5456,6 +5456,7 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,`
`5456`	`5456`	`boolhas_lockers;`
`5457`	`5457`	`TransactionIdupdate_xid;`
`5458`	`5458`	`boolupdate_committed;`
	`5459`	`+boolallow_old;`
`5459`	`5460`
`5460`	`5461`	`*flags=0;`
`5461`	`5462`
`@@ -5517,7 +5518,9 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,`
`5517`	`5518`	`* anything.`
`5518`	`5519`	`*/`
`5519`	`5520`
`5520`		`-nmembers=GetMultiXactIdMembers(multi,&members, false);`
	`5521`	`+allow_old= !(t_infomask&HEAP_LOCK_MASK)&&`
	`5522`	`+HEAP_XMAX_IS_LOCKED_ONLY(t_infomask);`
	`5523`	`+nmembers=GetMultiXactIdMembers(multi,&members,allow_old);`
`5521`	`5524`	`if (nmembers <=0)`
`5522`	`5525`	`{`
`5523`	`5526`	`/* Nothing worth keeping */`
`@@ -6219,10 +6222,13 @@ heap_tuple_needs_freeze(HeapTupleHeader tuple, TransactionId cutoff_xid,`
`6219`	`6222`	`MultiXactMember*members;`
`6220`	`6223`	`intnmembers;`
`6221`	`6224`	`inti;`
	`6225`	`+boolallow_old;`
`6222`	`6226`
`6223`	`6227`	`/* need to check whether any member of the mxact is too old */`
`6224`	`6228`
`6225`		`-nmembers=GetMultiXactIdMembers(multi,&members, false);`
	`6229`	`+allow_old= !(tuple->t_infomask&HEAP_LOCK_MASK)&&`
	`6230`	`+HEAP_XMAX_IS_LOCKED_ONLY(tuple->t_infomask);`
	`6231`	`+nmembers=GetMultiXactIdMembers(multi,&members,allow_old);`
`6226`	`6232`
`6227`	`6233`	`for (i=0;i<nmembers;i++)`
`6228`	`6234`	`{`

`‎src/backend/catalog/heap.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -911,7 +911,7 @@ AddNewRelationTuple(Relation pg_class_desc,`
`911`	`911`	`* commands/sequence.c.)`
`912`	`912`	`*/`
`913`	`913`	`new_rel_reltup->relfrozenxid=InvalidTransactionId;`
`914`		`-new_rel_reltup->relfrozenxid=InvalidMultiXactId;`
	`914`	`+new_rel_reltup->relminmxid=InvalidMultiXactId;`
`915`	`915`	`}`
`916`	`916`
`917`	`917`	`new_rel_reltup->relowner=relowner;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit423e121

File tree

2 files changed

2 files changed

`‎src/backend/access/heap/heapam.c`

`‎src/backend/catalog/heap.c`

0 commit comments