NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4225276

committed

Move check for USE_AVX512_POPCNT_WITH_RUNTIME_CHECK.

Unlike TRY_POPCNT_FAST, which is defined in pg_bitutils.h, thismacro is defined in c.h (via pg_config.h), so we can check for itearlier and avoid some unnecessary #includes on systems that lackAVX-512 support.Oversight in commitf78667b.Discussion:https://postgr.es/m/Zy5K5Qmlb3Z4dsd4%40nathan

1 parentb8df690 commit4225276Copy full SHA for 4225276

File tree

1 file changed

-5

lines changed

src/port
- pg_popcount_avx512.c

1 file changed

-5

lines changed

`‎src/port/pg_popcount_avx512.c`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,13 +12,13 @@`
`12`	`12`	`*/`
`13`	`13`	`#include"c.h"`
`14`	`14`
	`15`	`+#ifdefUSE_AVX512_POPCNT_WITH_RUNTIME_CHECK`
	`16`	`+`
`15`	`17`	`#if defined(HAVE__GET_CPUID)\|\| defined(HAVE__GET_CPUID_COUNT)`
`16`	`18`	`#include<cpuid.h>`
`17`	`19`	`#endif`
`18`	`20`
`19`		`-#ifdefUSE_AVX512_POPCNT_WITH_RUNTIME_CHECK`
`20`	`21`	`#include<immintrin.h>`
`21`		`-#endif`
`22`	`22`
`23`	`23`	`#if defined(HAVE__CPUID)\|\| defined(HAVE__CPUIDEX)`
`24`	`24`	`#include<intrin.h>`
`@@ -31,7 +31,7 @@`
`31`	`31`	`* use AVX-512 intrinsics, but we check it anyway to be sure. We piggy-back on`
`32`	`32`	`* the function pointers that are only used when TRY_POPCNT_FAST is set.`
`33`	`33`	`*/`
`34`		`-#if defined(TRY_POPCNT_FAST)&& defined(USE_AVX512_POPCNT_WITH_RUNTIME_CHECK)`
	`34`	`+#ifdefTRY_POPCNT_FAST`
`35`	`35`
`36`	`36`	`/*`
`37`	`37`	`* Does CPUID say there's support for XSAVE instructions?`
`@@ -219,5 +219,5 @@ pg_popcount_masked_avx512(const char *buf, int bytes, bits8 mask)`
`219`	`219`	`return_mm512_reduce_add_epi64(accum);`
`220`	`220`	`}`
`221`	`221`
`222`		`-#endif/* TRY_POPCNT_FAST&&`
`223`		`-* USE_AVX512_POPCNT_WITH_RUNTIME_CHECK */`
	`222`	`+#endif/* TRY_POPCNT_FAST*/`
	`223`	`+#endif/* USE_AVX512_POPCNT_WITH_RUNTIME_CHECK */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4225276

File tree

1 file changed

1 file changed

`‎src/port/pg_popcount_avx512.c`

0 commit comments