Commit41f613f

committed

Add HINT for restartpoint race with KeepFileRestoredFromArchive().

The five commits ending atcc2c7d6closed this race condition for v15+. For v14 through v10, add a HINT todiscourage studying the cosmetic problem.Reviewed by Kyotaro Horiguchi and David Steele.Discussion:https://postgr.es/m/20220731061747.GA3692882@rfd.leadboat.com

1 parent4ad4c1f commit41f613fCopy full SHA for 41f613f

File tree

+12

-3

lines changed

+12

-3

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3392,7 +3392,10 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)`
`3392`	`3392`	`if (fd<0)`
`3393`	`3393`	`ereport(ERROR,`
`3394`	`3394`	`(errcode_for_file_access(),`
`3395`		`-errmsg("could not open file \"%s\": %m",path)));`
	`3395`	`+errmsg("could not open file \"%s\": %m",path),`
	`3396`	`+ (AmCheckpointerProcess() ?`
	`3397`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`3398`	`+0)));`
`3396`	`3399`
`3397`	`3400`	`elog(DEBUG2,"done creating and filling new WAL file");`
`3398`	`3401`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -748,7 +748,10 @@ durable_link_or_rename(const char oldfile, const char newfile, int elevel)`
`748`	`748`	`ereport(elevel,`
`749`	`749`	`(errcode_for_file_access(),`
`750`	`750`	`errmsg("could not link file \"%s\" to \"%s\": %m",`
`751`		`-oldfile,newfile)));`
	`751`	`+oldfile,newfile),`
	`752`	`+ (AmCheckpointerProcess() ?`
	`753`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`754`	`+0)));`
`752`	`755`	`return-1;`
`753`	`756`	`}`
`754`	`757`	`unlink(oldfile);`
`@@ -759,7 +762,10 @@ durable_link_or_rename(const char oldfile, const char newfile, int elevel)`
`759`	`762`	`ereport(elevel,`
`760`	`763`	`(errcode_for_file_access(),`
`761`	`764`	`errmsg("could not rename file \"%s\" to \"%s\": %m",`
`762`		`-oldfile,newfile)));`
	`765`	`+oldfile,newfile),`
	`766`	`+ (AmCheckpointerProcess() ?`
	`767`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`768`	`+0)));`
`763`	`769`	`return-1;`
`764`	`770`	`}`
`765`	`771`	`#endif`

Comments

(0)