Commit41afaa1

committed

Account for IPC::Run::result() Windows behavior change.

This restores compatibility with the not-yet-released successor ofversion 20220807.0. Back-patch to 9.4, which introduced this code.Reviewed by Andrew Dunstan.Discussion:https://postgr.es/m/20221117061805.GA4020280@rfd.leadboat.com

1 parentcefe182 commit41afaa1Copy full SHA for 41afaa1

File tree

-8

lines changed

-8

lines changed

Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -782,15 +782,11 @@ sub command_exit_is`
`782`	`782`	`my$h = IPC::Run::start$cmd;`
`783`	`783`	`$h->finish();`
`784`	`784`
`785`		`-# On Windows, the exit status of the process is returned directly as the`
`786`		`-# process's exit code, while on Unix, it's returned in the high bits`
`787`		`-# of the exit code (see WEXITSTATUS macro in the standard <sys/wait.h>`
`788`		`-# header file). IPC::Run's result function always returns exit code >> 8,`
`789`		`-# assuming the Unix convention, which will always return 0 on Windows as`
`790`		`-# long as the process was not terminated by an exception. To work around`
`791`		`-# that, use $h->full_results on Windows instead.`
	`785`	`+# Normally, if the child called exit(N), IPC::Run::result() returns N. On`
	`786`	`+# Windows, with IPC::Run v20220807.0 and earlier, full_results() is the`
	`787`	`+# method that returns N (https://github.com/toddr/IPC-Run/issues/161).`
`792`	`788`	`my$result =`
`793`		`-($Config{osname}eq"MSWin32")`
	`789`	`+ ($Config{osname}eq"MSWin32" &&$IPC::Run::VERSION <= 20220807.0)`
`794`	`790`	`? ($h->full_results)[0]`
`795`	`791`	`:$h->result(0);`
`796`	`792`	`is($result,$expected,$test_name);`

Comments

(0)