Commit41820e6

committed

Fix memory leak in connection string validation.

Introduced in commitc3afe8c.Discussion:https://postgr.es/m/066a65233d3cb4ea27a9e0778d2f1d0dc764b222.camel@j-davis.comReviewed-by: Nathan Bossart, Tom LaneBackpatch-through: 16

1 parent4c03ac7 commit41820e6Copy full SHA for 41820e6

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -284,10 +284,15 @@ libpqrcv_check_conninfo(const char *conninfo, bool must_use_password)`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`if (!uses_password)`
	`287`	`+{`
	`288`	`+/* malloc'd, so we must free it explicitly */`
	`289`	`+PQconninfoFree(opts);`
	`290`	`+`
`287`	`291`	`ereport(ERROR,`
`288`	`292`	`(errcode(ERRCODE_S_R_E_PROHIBITED_SQL_STATEMENT_ATTEMPTED),`
`289`	`293`	`errmsg("password is required"),`
`290`	`294`	`errdetail("Non-superusers must provide a password in the connection string.")));`
	`295`	`+}`
`291`	`296`	`}`
`292`	`297`
`293`	`298`	`PQconninfoFree(opts);`

Comments

(0)