Commit4137207

committed

Fix crash when ALTER TABLE recreates indexes on partitions

The skip_build flag was not being passed correctly when recursing toindexes on partitions, leading to attempts to rebuild indexes when theywere not yet ready to be rebuilt.Reported-by: Rajkumar RaghuwanshiDiscussion:https://postgr.es/m/CAKcux6mxNCGsgATwf5CGMF8g4WSupCXicCVMeKUTuWbyxHOMsQ@mail.gmail.com

1 parentdad335b commit4137207Copy full SHA for 4137207

File tree

+18

-1

lines changed

+18

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1033,7 +1033,7 @@ DefineIndex(Oid relationId,`
`1033`	`1033`	`indexRelationId,/* this is our child */`
`1034`	`1034`	`createdConstraintId,`
`1035`	`1035`	`is_alter_table,check_rights,check_not_in_use,`
`1036`		`-false,quiet);`
	`1036`	`+skip_build,quiet);`
`1037`	`1037`	`}`
`1038`	`1038`
`1039`	`1039`	`pfree(attmap);`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,14 @@ SELECT col2 FROM idxpart_two fk LEFT OUTER JOIN idxpart pk ON (col1 = col2);`
`40`	`40`	`(0 rows)`
`41`	`41`
`42`	`42`	`DROP table idxpart, idxpart_two;`
	`43`	`+-- Verify bugfix with index rewrite on ALTER TABLE / SET DATA TYPE`
	`44`	`+-- https://postgr.es/m/CAKcux6mxNCGsgATwf5CGMF8g4WSupCXicCVMeKUTuWbyxHOMsQ@mail.gmail.com`
	`45`	`+CREATE TABLE idxpart (a INT, b TEXT, c INT) PARTITION BY RANGE(a);`
	`46`	`+CREATE TABLE idxpart1 PARTITION OF idxpart FOR VALUES FROM (MINVALUE) TO (MAXVALUE);`
	`47`	`+CREATE INDEX partidx_abc_idx ON idxpart (a, b, c);`
	`48`	`+INSERT INTO idxpart (a, b, c) SELECT i, i, i FROM generate_series(1, 50) i;`
	`49`	`+ALTER TABLE idxpart ALTER COLUMN c TYPE numeric;`
	`50`	`+DROP TABLE idxpart;`
`43`	`51`	`-- If a table without index is attached as partition to a table with`
`44`	`52`	`-- an index, the index is automatically created`
`45`	`53`	`create table idxpart (a int, b int, c text) partition by range (a);`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,15 @@ CREATE TABLE idxpart_two (col2 INT);`
`26`	`26`	`SELECT col2FROM idxpart_two fkLEFT OUTER JOIN idxpart pkON (col1= col2);`
`27`	`27`	`DROPtable idxpart, idxpart_two;`
`28`	`28`
	`29`	`+-- Verify bugfix with index rewrite on ALTER TABLE / SET DATA TYPE`
	`30`	`+-- https://postgr.es/m/CAKcux6mxNCGsgATwf5CGMF8g4WSupCXicCVMeKUTuWbyxHOMsQ@mail.gmail.com`
	`31`	`+CREATETABLEidxpart (aINT, bTEXT, cINT) PARTITION BY RANGE(a);`
	`32`	`+CREATETABLEidxpart1 PARTITION OF idxpart FORVALUESFROM (MINVALUE) TO (MAXVALUE);`
	`33`	`+CREATEINDEXpartidx_abc_idxON idxpart (a, b, c);`
	`34`	`+INSERT INTO idxpart (a, b, c)SELECT i, i, iFROM generate_series(1,50) i;`
	`35`	`+ALTERTABLE idxpart ALTER COLUMN c TYPEnumeric;`
	`36`	`+DROPTABLE idxpart;`
	`37`	`+`
`29`	`38`	`-- If a table without index is attached as partition to a table with`
`30`	`39`	`-- an index, the index is automatically created`
`31`	`40`	`createtableidxpart (aint, bint, ctext) partition by range (a);`

Comments

(0)