NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit40ddb8d

committed

Fix out-of-bound read in gtsvector_picksplit()

This could lead to an imprecise choice when splitting an index page of aGiST index on a tsvector, deciding which entries should remain on theold page and which entries should move to a new page.This is wrong since tsearch2 has been moved into core with commit140d4eb, so backpatch all the way down. This error has beenspotted by valgrind.Author: Alexander LakhinDiscussion:https://postgr.es/m/17950-6c80a8d2b94ec695@postgresql.orgBackpatch-through: 11

1 parenta67cf94 commit40ddb8dCopy full SHA for 40ddb8d

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- tsgistidx.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/tsgistidx.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,7 @@ gtsvector_picksplit(PG_FUNCTION_ARGS)`
`728`	`728`	`size_alpha=0;`
`729`	`729`	`else`
`730`	`730`	`size_alpha=SIGLENBIT-sizebitvec(`
`731`		`-(cache[j].allistrue) ?GETSIGN(datum_l) :GETSIGN(cache[j].sign)`
	`731`	`+(cache[j].allistrue) ?GETSIGN(datum_l) :cache[j].sign`
`732`	`732`	`);`
`733`	`733`	`}`
`734`	`734`	`else`
`@@ -740,7 +740,7 @@ gtsvector_picksplit(PG_FUNCTION_ARGS)`
`740`	`740`	`size_beta=0;`
`741`	`741`	`else`
`742`	`742`	`size_beta=SIGLENBIT-sizebitvec(`
`743`		`- (cache[j].allistrue) ?GETSIGN(datum_r) :GETSIGN(cache[j].sign)`
	`743`	`+ (cache[j].allistrue) ?GETSIGN(datum_r) :cache[j].sign`
`744`	`744`	`);`
`745`	`745`	`}`
`746`	`746`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit40ddb8d

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/tsgistidx.c`

0 commit comments