forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit40b1491

Amit Kapila
Fix incorrect output from pgoutput when using column lists.
For Updates and Deletes, we were not honoring the columns list for oldtuple values while sending tuple data via pgoutput. This results inpgoutput emitting more columns than expected.This is not a problem for built-in logical replication as we simply ignoreadditional columns based on the relation information sent previously whichdidn't have those columns. However, some other users of pgoutput pluginmay expect the columns as per the column list. Also, sending extra columnsunnecessarily consumes network bandwidth defeating the purpose of thecolumn list feature.Reported-by: Gunnar MorlingAuthor: Hou ZhijieReviewed-by: Amit KapilaBackpatch-through: 15Discussion:https://postgr.es/m/CADGJaX9kiRZ-OH0EpWF5Fkyh1ZZYofoNRCrhapBfdk02tj5EKg@mail.gmail.com1 parent069de07 commit40b1491
File tree
4 files changed
+42
-6
lines changed- src
- backend/replication
- logical
- pgoutput
- include/replication
- test/subscription/t
4 files changed
+42
-6
lines changedLines changed: 4 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
478 | 478 |
| |
479 | 479 |
| |
480 | 480 |
| |
481 |
| - | |
| 481 | + | |
482 | 482 |
| |
483 | 483 |
| |
484 | 484 |
| |
| |||
531 | 531 |
| |
532 | 532 |
| |
533 | 533 |
| |
534 |
| - | |
| 534 | + | |
| 535 | + | |
535 | 536 |
| |
536 | 537 |
| |
537 | 538 |
| |
| |||
551 | 552 |
| |
552 | 553 |
| |
553 | 554 |
| |
554 |
| - | |
| 555 | + | |
555 | 556 |
| |
556 | 557 |
| |
557 | 558 |
| |
|
Lines changed: 4 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1532 | 1532 |
| |
1533 | 1533 |
| |
1534 | 1534 |
| |
1535 |
| - | |
| 1535 | + | |
| 1536 | + | |
1536 | 1537 |
| |
1537 | 1538 |
| |
1538 | 1539 |
| |
| |||
1578 | 1579 |
| |
1579 | 1580 |
| |
1580 | 1581 |
| |
1581 |
| - | |
| 1582 | + | |
| 1583 | + | |
1582 | 1584 |
| |
1583 | 1585 |
| |
1584 | 1586 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
220 | 220 |
| |
221 | 221 |
| |
222 | 222 |
| |
223 |
| - | |
| 223 | + | |
224 | 224 |
| |
225 | 225 |
| |
226 | 226 |
| |
|
Lines changed: 33 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1151 | 1151 |
| |
1152 | 1152 |
| |
1153 | 1153 |
| |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
1154 | 1187 |
| |
1155 | 1188 |
| |
1156 | 1189 |
| |
|
0 commit comments
Comments
(0)