NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit4093ff5

committed

Store the deletion horizon XID for a deleted GIN page on the right page.

Commitb107140 moved the GinPageSetDeleteXid() call to a spot wherethe "page" variable was pointing to the wrong page, causing the XIDto be inserted on a page that's not being deleted, thus allowing laterGinPageIsRecyclable tests to recycle the deleted page too soon.It might be a good idea to stop using the single "page" variable formultiple purposes in this function. But for the moment I just movedthe GinPageSetDeleteXid() call down beside the GinPageSetDeleted()call, which seems like a more logical place for it anyway.Back-patch to v11, as the faulty patch was. (Fortunately, the bughasn't made it into any release yet.)Discussion:https://postgr.es/m/21620.1581098806@sss.pgh.pa.us

1 parent55173d2 commit4093ff5Copy full SHA for 4093ff5

File tree

1 file changed

-3

lines changed

src/backend/access/gin
- ginvacuum.c

1 file changed

-3

lines changed

`‎src/backend/access/gin/ginvacuum.c`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,9 +165,6 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn`
`165`	`165`	`page=BufferGetPage(lBuffer);`
`166`	`166`	`GinPageGetOpaque(page)->rightlink=rightlink;`
`167`	`167`
`168`		`-/* For deleted page remember last xid which could knew its address */`
`169`		`-GinPageSetDeleteXid(page,ReadNewTransactionId());`
`170`		`-`
`171`	`168`	`/* Delete downlink from parent */`
`172`	`169`	`parentPage=BufferGetPage(pBuffer);`
`173`	`170`	`#ifdefUSE_ASSERT_CHECKING`
`@@ -186,7 +183,13 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn`
`186`	`183`	`* we shouldn't change rightlink field to save workability of running`
`187`	`184`	`* search scan`
`188`	`185`	`*/`
	`186`	`+`
	`187`	`+/*`
	`188`	`+ * Mark page as deleted, and remember last xid which could know its`
	`189`	`+ * address.`
	`190`	`+ */`
`189`	`191`	`GinPageSetDeleted(page);`
	`192`	`+GinPageSetDeleteXid(page,ReadNewTransactionId());`
`190`	`193`
`191`	`194`	`MarkBufferDirty(pBuffer);`
`192`	`195`	`MarkBufferDirty(lBuffer);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4093ff5

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginvacuum.c`

0 commit comments