forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit407cb6c
committed
Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIPPING
It's important for 'all_visible_according_to_vm' to correctly reflectwhether the VM bit is set or not, even when we are not trusting the VMto skip pages, because contrary to what the comment said,lazy_scan_prune() relies on it.If it's incorrectly set to 'false', when the VM bit is in fact set,lazy_scan_prune() will try to set the VM bit again and dirty the pageunnecessarily. As a result, if you used DISABLE_PAGE_SKIPPING, allheap pages were dirtied, even if there were no changes. We would alsofail to clear any VM bits that were set incorrectly.This was broken in commit980ae17, so backpatch to v16.Backpatch-through: 16Reviewed-by: Melanie Plageman, Peter GeogheganDiscussion:https://www.postgresql.org/message-id/3df2b582-dc1c-46b6-99b6-38eddd1b2784@iki.fi1 parent348233c commit407cb6c
1 file changed
+0
-4
lines changedLines changed: 0 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1330 | 1330 |
| |
1331 | 1331 |
| |
1332 | 1332 |
| |
1333 |
| - | |
1334 |
| - | |
1335 |
| - | |
1336 | 1333 |
| |
1337 |
| - | |
1338 | 1334 |
| |
1339 | 1335 |
| |
1340 | 1336 |
| |
|
0 commit comments
Comments
(0)