NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3feb6ac

committed

Check after errors of SPI_execute() in xml.c

SPI gets used to build a list of relation OIDs for XML objectgeneration, and one code path building a list uses SPI_execute() withoutlooking at errors it produces. So fix that.Author: Mark DilgerReviewed-by: Michael Paquier, Pavel StehuleDiscussion:https://postgr.es/m/17d30445-4862-7917-170f-84328dcd292d@gmail.com

1 parent6e3e6cc commit3feb6acCopy full SHA for 3feb6ac

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- xml.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/xml.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2461,8 +2461,12 @@ query_to_oid_list(const char *query)`
`2461`	`2461`	`{`
`2462`	`2462`	`uint64i;`
`2463`	`2463`	`List*list=NIL;`
	`2464`	`+intspi_result;`
`2464`	`2465`
`2465`		`-SPI_execute(query, true,0);`
	`2466`	`+spi_result=SPI_execute(query, true,0);`
	`2467`	`+if (spi_result!=SPI_OK_SELECT)`
	`2468`	`+elog(ERROR,"SPI_execute returned %s for %s",`
	`2469`	`+SPI_result_code_string(spi_result),query);`
`2466`	`2470`
`2467`	`2471`	`for (i=0;i<SPI_processed;i++)`
`2468`	`2472`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3feb6ac

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/xml.c`

0 commit comments