Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit3fd36be

Browse files
committed
Abort pgbench if script end is reached with an open pipeline
When a pipeline is opened with \startpipeline and not closed, pgbenchwill either error on the next transaction with a "already in pipelinemode" error or successfully end if this was the last transaction --despite not sending anything that was piped in the pipeline.Make it an error to reach end of script is reached while there's anopen pipeline.Backpatch to 14, where pgbench got support for pipelines.Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>Reported-by: Michael Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/Za4IObZkDjrO4TcS@paquier.xyz
1 parentde2d393 commit3fd36be

File tree

2 files changed

+41
-2
lines changed

2 files changed

+41
-2
lines changed

‎src/bin/pgbench/pgbench.c

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3778,10 +3778,21 @@ advanceConnectionState(TState *thread, CState *st, StatsData *agg)
37783778
caseCSTATE_START_COMMAND:
37793779
command=sql_script[st->use_file].commands[st->command];
37803780

3781-
/* Transition to script end processing if done */
3781+
/*
3782+
* Transition to script end processing if done, but close up
3783+
* shop if a pipeline is open at this point.
3784+
*/
37823785
if (command==NULL)
37833786
{
3784-
st->state=CSTATE_END_TX;
3787+
if (PQpipelineStatus(st->con)==PQ_PIPELINE_OFF)
3788+
st->state=CSTATE_END_TX;
3789+
else
3790+
{
3791+
pg_log_error("client %d aborted: end of script reached with pipeline open",
3792+
st->id);
3793+
st->state=CSTATE_ABORTED;
3794+
}
3795+
37853796
break;
37863797
}
37873798

‎src/bin/pgbench/t/001_pgbench_with_server.pl

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,34 @@
841841
}
842842
});
843843

844+
# Try \startpipeline without \endpipeline in a single transaction
845+
$node->pgbench(
846+
'-t 1 -n -M extended',
847+
2,
848+
[],
849+
[qr{end of script reached with pipeline open}],
850+
'error: call \startpipeline without \endpipeline in a single transaction',
851+
{
852+
'001_pgbench_pipeline_5'=>q{
853+
-- startpipeline only with single transaction
854+
\startpipeline
855+
}
856+
});
857+
858+
# Try \startpipeline without \endpipeline
859+
$node->pgbench(
860+
'-t 2 -n -M extended',
861+
2,
862+
[],
863+
[qr{end of script reached with pipeline open}],
864+
'error: call \startpipeline without \endpipeline',
865+
{
866+
'001_pgbench_pipeline_6'=>q{
867+
-- startpipeline only
868+
\startpipeline
869+
}
870+
});
871+
844872
# Working \startpipeline in prepared query mode with serializable
845873
$node->pgbench(
846874
'-c4 -t 10 -n -M prepared',

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp