Commit3f9aace

Michael Meskes

committed

Added some more coverity report patches send in by Martijn van Oosterhout <kleptog@svana.org>.

1 parent6bba431 commit3f9aaceCopy full SHA for 3f9aace

File tree

+13

-5

lines changed

+13

-5

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2021,5 +2021,10 @@ We Jun 21 09:24:53 CEST 2006`
`2021`	`2021`	`- Added fixes from the coverity report send in by Joachim Wieland`
`2022`	`2022`	`<joe@mcknight.de>.`
`2023`	`2023`	`- Added missing error handling in a few functions in ecpglib.`
	`2024`	`+`
	`2025`	`+we Jun 21 13:37:00 CEST 2006`
	`2026`	`+`
	`2027`	`+- Added some more coverity report patches send in by Martijn van`
	`2028`	`+ Oosterhout <kleptog@svana.org>.`
`2024`	`2029`	`- Set ecpg library version to 5.2.`
`2025`	`2030`	`- Set ecpg version to 4.2.1.`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/connect.c,v 1.29 2006/06/2110:24:40 meskes Exp $ */`
	`1`	`+/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/connect.c,v 1.30 2006/06/2111:38:07 meskes Exp $ */`
`2`	`2`
`3`	`3`	`#definePOSTGRES_ECPG_INTERNAL`
`4`	`4`	`#include"postgres_fe.h"`
`@@ -227,6 +227,9 @@ ECPGnoticeReceiver(void arg, const PGresult result)`
`227`	`227`	`if (sqlstate==NULL)`
`228`	`228`	`sqlstate=ECPG_SQLSTATE_ECPG_INTERNAL_ERROR;`
`229`	`229`
	`230`	`+if (message==NULL)/* Shouldn't happen, but need to be sure */`
	`231`	`+message="No message received";`
	`232`	`+`
`230`	`233`	`/* these are not warnings */`
`231`	`234`	`if (strncmp(sqlstate,"00",2)==0)`
`232`	`235`	`return;`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/execute.c,v 1.47 2006/06/2110:24:40 meskes Exp $ */`
	`1`	`+/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/execute.c,v 1.48 2006/06/2111:38:07 meskes Exp $ */`
`2`	`2`
`3`	`3`	`/*`
`4`	`4`	`* The aim is to get a simpler inteface to the database routines.`
`@@ -891,7 +891,6 @@ ECPGstore_input(const int lineno, const bool force_indicator, const struct varia`
`891`	`891`	`PGTYPESnumeric_from_decimal((decimal) ((var+var->offsetelement)->value),nval);`
`892`	`892`
`893`	`893`	`str=PGTYPESnumeric_to_asc(nval,nval->dscale);`
`894`		`-PGTYPESnumeric_free(nval);`
`895`	`894`	`slen=strlen(str);`
`896`	`895`
`897`	`896`	`if (!(mallocedval=ECPGrealloc(mallocedval,strlen(mallocedval)+slen+sizeof("array [] "),lineno)))`
`@@ -907,6 +906,7 @@ ECPGstore_input(const int lineno, const bool force_indicator, const struct varia`
`907`	`906`	`strncpy(mallocedval+strlen(mallocedval),str,slen+1);`
`908`	`907`	`strcpy(mallocedval+strlen(mallocedval),",");`
`909`	`908`	`}`
	`909`	`+PGTYPESnumeric_free(nval);`
`910`	`910`	`strcpy(mallocedval+strlen(mallocedval)-1,"]");`
`911`	`911`	`}`
`912`	`912`	`else`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/misc.c,v 1.26 2005/10/15 02:49:47 momjian Exp $ */`
	`1`	`+/* $PostgreSQL: pgsql/src/interfaces/ecpg/ecpglib/misc.c,v 1.27 2006/06/21 11:38:07 meskes Exp $ */`
`2`	`2`
`3`	`3`	`#definePOSTGRES_ECPG_INTERNAL`
`4`	`4`	`#include"postgres_fe.h"`
`@@ -179,7 +179,7 @@ ECPGtrans(int lineno, const char connection_name, const char transaction)`
`179`	`179`	`if (!ECPGinit(con,connection_name,lineno))`
`180`	`180`	`return (false);`
`181`	`181`
`182`		`-ECPGlog("ECPGtrans line %d action = %s connection = %s\n",lineno,transaction,con->name);`
	`182`	`+ECPGlog("ECPGtrans line %d action = %s connection = %s\n",lineno,transaction,con ?con->name :"(nil)");`
`183`	`183`
`184`	`184`	`/* if we have no connection we just simulate the command */`
`185`	`185`	`if (con&&con->connection)`

Comments

(0)