forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit3f96af4
committed
Un-break pg_upgrade from pre-v12 servers.
I neglected to test this scenario while preparing commitf3faf35,so of course it was broken, thanks to some very obscure and undocumentedcode in pg_dump. Pre-v12 databases might have toast tables attached topartitioned tables, which we need to ignore since newer servers nevercreate such useless toast tables. There was a filter for this case inbinary_upgrade_set_type_oids_by_rel_oid(), which appeared to justprevent the pg_type OID from being copied. But actually it managed toprevent the toast table from being created at all --- or it did beforeI took out that logic. But that was a fundamentally bizarre place to bemaking the test in the first place. The place where the filter shouldhave been, one would think, is binary_upgrade_set_pg_class_oids(), soadd it there.While at it, reorganize binary_upgrade_set_pg_class_oids() so that itdoesn't make a completely useless query when it knows it's beinginvoked for an index. And correct a comment that mis-described thescenario where we need to force creation of a TOAST table.Per buildfarm.1 parentf3faf35 commit3f96af4
1 file changed
+44
-31
lines changedLines changed: 44 additions & 31 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4525 | 4525 |
| |
4526 | 4526 |
| |
4527 | 4527 |
| |
4528 |
| - | |
4529 |
| - | |
4530 |
| - | |
4531 |
| - | |
4532 |
| - | |
4533 |
| - | |
4534 |
| - | |
4535 |
| - | |
4536 |
| - | |
4537 |
| - | |
4538 |
| - | |
4539 |
| - | |
4540 |
| - | |
4541 |
| - | |
4542 |
| - | |
4543 |
| - | |
4544 |
| - | |
4545 | 4528 |
| |
4546 | 4529 |
| |
4547 | 4530 |
| |
4548 | 4531 |
| |
4549 | 4532 |
| |
| 4533 | + | |
| 4534 | + | |
| 4535 | + | |
| 4536 | + | |
| 4537 | + | |
| 4538 | + | |
4550 | 4539 |
| |
4551 | 4540 |
| |
4552 | 4541 |
| |
4553 |
| - | |
4554 |
| - | |
4555 |
| - | |
4556 |
| - | |
4557 |
| - | |
4558 |
| - | |
4559 |
| - | |
4560 |
| - | |
4561 |
| - | |
4562 |
| - | |
4563 |
| - | |
4564 | 4542 |
| |
| 4543 | + | |
| 4544 | + | |
| 4545 | + | |
| 4546 | + | |
| 4547 | + | |
| 4548 | + | |
| 4549 | + | |
| 4550 | + | |
| 4551 | + | |
| 4552 | + | |
| 4553 | + | |
| 4554 | + | |
| 4555 | + | |
| 4556 | + | |
| 4557 | + | |
| 4558 | + | |
| 4559 | + | |
| 4560 | + | |
| 4561 | + | |
| 4562 | + | |
| 4563 | + | |
| 4564 | + | |
| 4565 | + | |
| 4566 | + | |
| 4567 | + | |
| 4568 | + | |
| 4569 | + | |
| 4570 | + | |
| 4571 | + | |
| 4572 | + | |
| 4573 | + | |
| 4574 | + | |
| 4575 | + | |
| 4576 | + | |
| 4577 | + | |
4565 | 4578 |
| |
4566 | 4579 |
| |
4567 | 4580 |
| |
| |||
4571 | 4584 |
| |
4572 | 4585 |
| |
4573 | 4586 |
| |
| 4587 | + | |
| 4588 | + | |
| 4589 | + | |
4574 | 4590 |
| |
4575 | 4591 |
| |
4576 | 4592 |
| |
4577 | 4593 |
| |
4578 | 4594 |
| |
4579 | 4595 |
| |
4580 | 4596 |
| |
4581 |
| - | |
4582 |
| - | |
4583 |
| - | |
4584 | 4597 |
| |
4585 | 4598 |
| |
4586 | 4599 |
| |
|
0 commit comments
Comments
(0)