NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3f695b3

committed

sequences: Lock buffer before initializing page

fill_seq_fork_with_data(), used to initialize a new sequence relation, onlylocked the buffer after calling PageInit(), even though PageInit() modifiespage contents.This is unlikely to cause real-world issues, as the relation is exclusivelylocked at that point, and the buffer not yet marked dirty, so other processesshould not access the buffer.This issue looks to have been present since the introduction of sequences ine8647c4.Given the low risk, it does not seem worth backpatching the fix.Discussion:https://postgr.es/m/20230404185501.wdkmo3k7bedlx6qk@awork3.anarazel.de

1 parente126d81 commit3f695b3Copy full SHA for 3f695b3

File tree

1 file changed

-3

lines changed

src/backend/commands
- sequence.c

1 file changed

-3

lines changed

`‎src/backend/commands/sequence.c`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ fill_seq_fork_with_data(Relation rel, HeapTuple tuple, ForkNumber forkNum)`
`377`	`377`
`378`	`378`	`/* Initialize first page of relation with special magic number */`
`379`	`379`
`380`		`-buf=ReadBufferExtended(rel,forkNum,P_NEW,RBM_NORMAL,NULL);`
	`380`	`+buf=ReadBufferExtended(rel,forkNum,P_NEW,RBM_ZERO_AND_LOCK,NULL);`
`381`	`381`	`Assert(BufferGetBlockNumber(buf)==0);`
`382`	`382`
`383`	`383`	`page=BufferGetPage(buf);`
`@@ -388,8 +388,6 @@ fill_seq_fork_with_data(Relation rel, HeapTuple tuple, ForkNumber forkNum)`
`388`	`388`
`389`	`389`	`/* Now insert sequence tuple */`
`390`	`390`
`391`		`-LockBuffer(buf,BUFFER_LOCK_EXCLUSIVE);`
`392`		`-`
`393`	`391`	`/*`
`394`	`392`	`* Since VACUUM does not process sequences, we have to force the tuple to`
`395`	`393`	`* have xmin = FrozenTransactionId now. Otherwise it would become`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3f695b3

File tree

1 file changed

1 file changed

`‎src/backend/commands/sequence.c`

0 commit comments