Commit3f5863e

committed

pg_upgrade: set vacuum_defer_cleanup_age to zero

Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing ofthe system catalogs to be incomplete, or do nothing. This will causethe upgrade to fail in confusing ways.Reported-by: Laurenz AlbeDiscussion:https://postgr.es/m/7d6f6c22ba05ce0c526e9e8b7bfa8105e7da45e6.camel@cybertec.atBackpatch-through: 9.5

1 parent5674eb9 commit3f5863eCopy full SHA for 3f5863e

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,9 @@ start_postmaster(ClusterInfo *cluster, bool report_and_exit_on_error)`
`239`	`239`	`* we only modify the new cluster, so only use it there. If there is a`
`240`	`240`	`* crash, the new cluster has to be recreated anyway. fsync=off is a big`
`241`	`241`	`* win on ext4.`
	`242`	`+ *`
	`243`	`+ * Force vacuum_defer_cleanup_age to 0 on the new cluster, so that`
	`244`	`+ * vacuumdb --freeze actually freezes the tuples.`
`242`	`245`	`*/`
`243`	`246`	`snprintf(cmd,sizeof(cmd),`
`244`	`247`	`"\"%s/pg_ctl\" -w -l \"%s\" -D \"%s\" -o \"-p %d%s%s %s%s\" start",`
`@@ -247,7 +250,7 @@ start_postmaster(ClusterInfo *cluster, bool report_and_exit_on_error)`
`247`	`250`	`BINARY_UPGRADE_SERVER_FLAG_CAT_VER) ?" -b" :`
`248`	`251`	`" -c autovacuum=off -c autovacuum_freeze_max_age=2000000000",`
`249`	`252`	`(cluster==&new_cluster) ?`
`250`		`-" -c synchronous_commit=off -c fsync=off -c full_page_writes=off" :"",`
	`253`	`+" -c synchronous_commit=off -c fsync=off -c full_page_writes=off -c vacuum_defer_cleanup_age=0" :"",`
`251`	`254`	`cluster->pgopts ?cluster->pgopts :"",socket_string);`
`252`	`255`
`253`	`256`	`/*`

Comments

(0)