NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3ed76bd

committed

Check for fseeko() failure in pg_dump's _tarAddFile().

Coverity pointed out, not unreasonably, that we checked fseeko'sresult at every other call site but these. Failure to seek in thetemp file (note this is NOT pg_dump's output file) seems quiteunlikely, and even if it did happen the file length cross-checkfurther down would probably detect the problem. Still, that's apoor excuse for not checking the result of a system call.

1 parent29cfa88 commit3ed76bdCopy full SHA for 3ed76bd

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- pg_backup_tar.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/pg_backup_tar.c‎`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1096,12 +1096,16 @@ _tarAddFile(ArchiveHandle AH, TAR_MEMBER th)`
`1096`	`1096`	`/*`
`1097`	`1097`	`* Find file len & go back to start.`
`1098`	`1098`	`*/`
`1099`		`-fseeko(tmp,0,SEEK_END);`
	`1099`	`+if (fseeko(tmp,0,SEEK_END)!=0)`
	`1100`	`+exit_horribly(modulename,"error during file seek: %s\n",`
	`1101`	`+strerror(errno));`
`1100`	`1102`	`th->fileLen=ftello(tmp);`
`1101`	`1103`	`if (th->fileLen<0)`
`1102`	`1104`	`exit_horribly(modulename,"could not determine seek position in archive file: %s\n",`
`1103`	`1105`	`strerror(errno));`
`1104`		`-fseeko(tmp,0,SEEK_SET);`
	`1106`	`+if (fseeko(tmp,0,SEEK_SET)!=0)`
	`1107`	`+exit_horribly(modulename,"error during file seek: %s\n",`
	`1108`	`+strerror(errno));`
`1105`	`1109`
`1106`	`1110`	`_tarWriteHeader(th);`
`1107`	`1111`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3ed76bd

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_backup_tar.c‎`

0 commit comments