Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit3eb8eec

Browse files
committed
Remove obsolete comments and code from prior tof8f4227.
XLogReadBufferForRedo() and XLogReadBufferForRedoExtended() only returnBLK_NEEDS_REDO if the record LSN is greater than the page LSN, sothe redo routine doesn't need to do the LSN check again.Discussion:https://postgr.es/m/0c37b80e62b1f3007d5a6d1292bd8fa0c275627a.camel@j-davis.com
1 parent373679c commit3eb8eec

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

‎src/backend/access/heap/heapam.c‎

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8827,12 +8827,6 @@ heap_xlog_visible(XLogReaderState *record)
88278827
* full-page writes. This exposes us to torn page hazards, but since
88288828
* we're not inspecting the existing page contents in any way, we
88298829
* don't care.
8830-
*
8831-
* However, all operations that clear the visibility map bit *do* bump
8832-
* the LSN, and those operations will only be replayed if the XLOG LSN
8833-
* follows the page LSN. Thus, if the page LSN has advanced past our
8834-
* XLOG record's LSN, we mustn't mark the page all-visible, because
8835-
* the subsequent update won't be replayed to clear the flag.
88368830
*/
88378831
page=BufferGetPage(buffer);
88388832

@@ -8901,20 +8895,8 @@ heap_xlog_visible(XLogReaderState *record)
89018895
reln=CreateFakeRelcacheEntry(rlocator);
89028896
visibilitymap_pin(reln,blkno,&vmbuffer);
89038897

8904-
/*
8905-
* Don't set the bit if replay has already passed this point.
8906-
*
8907-
* It might be safe to do this unconditionally; if replay has passed
8908-
* this point, we'll replay at least as far this time as we did
8909-
* before, and if this bit needs to be cleared, the record responsible
8910-
* for doing so should be again replayed, and clear it. For right
8911-
* now, out of an abundance of conservatism, we use the same test here
8912-
* we did for the heap page. If this results in a dropped bit, no
8913-
* real harm is done; and the next VACUUM will fix it.
8914-
*/
8915-
if (lsn>PageGetLSN(vmpage))
8916-
visibilitymap_set(reln,blkno,InvalidBuffer,lsn,vmbuffer,
8917-
xlrec->cutoff_xid,xlrec->flags);
8898+
visibilitymap_set(reln,blkno,InvalidBuffer,lsn,vmbuffer,
8899+
xlrec->cutoff_xid,xlrec->flags);
89188900

89198901
ReleaseBuffer(vmbuffer);
89208902
FreeFakeRelcacheEntry(reln);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp