NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3ea56ff

committed

Don't rename .partial files in pg_receivexlog if an error occured

In56c7d8d the behavior to keep .partial segments around(considered corrupt) in case an connection failure occurs wasaccidentally removed. This would lead to an incomplete segmentbeing considered complete.Author: Michael Paquier

1 parent6cfa54e commit3ea56ffCopy full SHA for 3ea56ff

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- receivelog.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/receivelog.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -679,7 +679,7 @@ ReceiveXlogStream(PGconn conn, StreamCtl stream)`
`679`	`679`	`}`
`680`	`680`
`681`	`681`	`error:`
`682`		`-if (walfile!=NULL&&stream->walmethod->close(walfile,CLOSE_NORMAL)!=0)`
	`682`	`+if (walfile!=NULL&&stream->walmethod->close(walfile,CLOSE_NO_RENAME)!=0)`
`683`	`683`	`fprintf(stderr,_("%s: could not close file \"%s\": %s\n"),`
`684`	`684`	`progname,current_walfile_name,stream->walmethod->getlasterror());`
`685`	`685`	`walfile=NULL;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3ea56ff

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/receivelog.c`

0 commit comments