NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3e67a5c

Amit Kapila

committed

Remove some useless free calls.

These were introduced in recent commit52e4f0c. We were trying to freesome transient space consumption and that too was not entirely correct andcomplete. We don't need this partial freeing of memory as it will beallocated just once for a query and will be freed at the end of the query.Author: Zhihong YuReviewed-by: Amit KapilaDiscussion:https://postgr.es/m/CALNJ-vQORfQ=vicbKA_RmeGZGzm1y3WsEcZqXWi7qjN43Cz_vg@mail.gmail.com

1 parent0f79caa commit3e67a5cCopy full SHA for 3e67a5c

File tree

1 file changed

-6

lines changed

src/backend/commands
- publicationcmds.c

1 file changed

-6

lines changed

`‎src/backend/commands/publicationcmds.c`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -409,9 +409,6 @@ contain_invalid_rfcolumn(Oid pubid, Relation relation, List *ancestors,`
`409`	`409`	`context.bms_replident=bms;`
`410`	`410`	`rfnode=stringToNode(TextDatumGetCString(rfdatum));`
`411`	`411`	`result=contain_invalid_rfcolumn_walker(rfnode,&context);`
`412`		`-`
`413`		`-bms_free(bms);`
`414`		`-pfree(rfnode);`
`415`	`412`	`}`
`416`	`413`
`417`	`414`	`ReleaseSysCache(rftuple);`
`@@ -1182,9 +1179,6 @@ AlterPublicationTables(AlterPublicationStmt *stmt, HeapTuple tup,`
`1182`	`1179`	`}`
`1183`	`1180`	`}`
`1184`	`1181`
`1185`		`-if (oldrelwhereclause)`
`1186`		`-pfree(oldrelwhereclause);`
`1187`		`-`
`1188`	`1182`	`/*`
`1189`	`1183`	`* Add the non-matched relations to a list so that they can be`
`1190`	`1184`	`* dropped.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3e67a5c

File tree

1 file changed

1 file changed

`‎src/backend/commands/publicationcmds.c`

0 commit comments