NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3e32109

committed

Use key and partdesc from PartitionDispatch where possible.

Instead of repeatedly fishing the data out of the relcache entry,let's use the version that we cached in the PartitionDispatch. Wecould alternatively rip out the PartitionDispatch fields altogether,but it doesn't make much sense to have them and not use them; beforethis patch, partdesc was set but altogether unused. Amit Langote andI both thought using them was a litle better than removing them, sothis patch takes that approach.Discussion:http://postgr.es/m/CA+TgmobFnxcaW-Co-XO8=yhJ5pJXoNkCj6Z7jm9Mwj9FGv-D7w@mail.gmail.com

1 parent8ce29bb commit3e32109Copy full SHA for 3e32109

File tree

1 file changed

-8

lines changed

src/backend/executor
- execPartition.c

1 file changed

-8

lines changed

`‎src/backend/executor/execPartition.c`

Lines changed: 6 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ static void FormPartitionKeyDatum(PartitionDispatch pd,`
`41`	`41`	`EState*estate,`
`42`	`42`	`Datum*values,`
`43`	`43`	`bool*isnull);`
`44`		`-staticintget_partition_for_tuple(Relationrelation,Datum*values,`
	`44`	`+staticintget_partition_for_tuple(PartitionDispatchpd,Datum*values,`
`45`	`45`	`bool*isnull);`
`46`	`46`	`staticchar*ExecBuildSlotPartitionKeyDescription(Relationrel,`
`47`	`47`	`Datum*values,`
`@@ -208,13 +208,11 @@ ExecFindPartition(ResultRelInfo resultRelInfo, PartitionDispatch pd,`
`208`	`208`	`parent=pd[0];`
`209`	`209`	`while (true)`
`210`	`210`	`{`
`211`		`-PartitionDescpartdesc;`
`212`	`211`	`TupleTableSlot*myslot=parent->tupslot;`
`213`	`212`	`TupleConversionMap*map=parent->tupmap;`
`214`	`213`	`intcur_index=-1;`
`215`	`214`
`216`	`215`	`rel=parent->reldesc;`
`217`		`-partdesc=RelationGetPartitionDesc(rel);`
`218`	`216`
`219`	`217`	`/*`
`220`	`218`	`* Convert the tuple to this parent's layout so that we can do certain`
`@@ -245,13 +243,13 @@ ExecFindPartition(ResultRelInfo resultRelInfo, PartitionDispatch pd,`
`245`	`243`	`* Nothing for get_partition_for_tuple() to do if there are no`
`246`	`244`	`* partitions to begin with.`
`247`	`245`	`*/`
`248`		`-if (partdesc->nparts==0)`
	`246`	`+if (parent->partdesc->nparts==0)`
`249`	`247`	`{`
`250`	`248`	`result=-1;`
`251`	`249`	`break;`
`252`	`250`	`}`
`253`	`251`
`254`		`-cur_index=get_partition_for_tuple(rel,values,isnull);`
	`252`	`+cur_index=get_partition_for_tuple(parent,values,isnull);`
`255`	`253`
`256`	`254`	`/*`
`257`	`255`	`* cur_index < 0 means we failed to find a partition of this parent.`
`@@ -1079,12 +1077,12 @@ FormPartitionKeyDatum(PartitionDispatch pd,`
`1079`	`1077`	`* found or -1 if none found.`
`1080`	`1078`	`*/`
`1081`	`1079`	`staticint`
`1082`		`-get_partition_for_tuple(Relationrelation,Datumvalues,boolisnull)`
	`1080`	`+get_partition_for_tuple(PartitionDispatchpd,Datumvalues,boolisnull)`
`1083`	`1081`	`{`
`1084`	`1082`	`intbound_offset;`
`1085`	`1083`	`intpart_index=-1;`
`1086`		`-PartitionKeykey=RelationGetPartitionKey(relation);`
`1087`		`-PartitionDescpartdesc=RelationGetPartitionDesc(relation);`
	`1084`	`+PartitionKeykey=pd->key;`
	`1085`	`+PartitionDescpartdesc=pd->partdesc;`
`1088`	`1086`	`PartitionBoundInfoboundinfo=partdesc->boundinfo;`
`1089`	`1087`
`1090`	`1088`	`/* Route as appropriate based on partitioning strategy. */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3e32109

File tree

1 file changed

1 file changed

`‎src/backend/executor/execPartition.c`

0 commit comments