Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit3e20a72

Browse files
committed
Make all valid uses of the COLLATE clause yield the same result: a syntax
error. There is no point in providing some kind of forward compatibilitynow, because no one can tell what a future implementation will look like.
1 parent4060f07 commit3e20a72

File tree

1 file changed

+4
-30
lines changed

1 file changed

+4
-30
lines changed

‎src/backend/parser/gram.y

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*
1212
*
1313
* IDENTIFICATION
14-
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.430 2003/08/22 20:34:33 tgl Exp $
14+
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.431 2003/09/06 14:01:51 petere Exp $
1515
*
1616
* HISTORY
1717
* AUTHORDATEMAJOR EVENT
@@ -294,7 +294,7 @@ static void doNegateFloat(Value *v);
294294
BitConstBitBitWithLengthBitWithoutLength
295295
%type<str>character
296296
%type<str>extract_arg
297-
%type<str>opt_charsetopt_collate
297+
%type<str>opt_charset
298298
%type<ival>opt_numericopt_decimal
299299
%type<boolean>opt_varyingopt_timezone
300300

@@ -441,7 +441,6 @@ static void doNegateFloat(Value *v);
441441
%rightUMINUS
442442
%left'['']'
443443
%left'('')'
444-
%leftCOLLATE
445444
%leftTYPECAST
446445
%left'.'
447446
/*
@@ -1461,19 +1460,13 @@ TableElement:
14611460
|TableConstraint{$$ =$1; }
14621461
;
14631462

1464-
columnDef:ColIdTypenameColQualListopt_collate
1463+
columnDef:ColIdTypenameColQualList
14651464
{
14661465
ColumnDef *n = makeNode(ColumnDef);
14671466
n->colname =$1;
14681467
n->typename =$2;
14691468
n->constraints =$3;
14701469
n->is_local =true;
1471-
1472-
if ($4 !=NULL)
1473-
ereport(NOTICE,
1474-
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
1475-
errmsg("CREATE TABLE / COLLATE is not yet implemented; clause ignored")));
1476-
14771470
$$ = (Node *)n;
14781471
}
14791472
;
@@ -3843,17 +3836,12 @@ DropdbStmt: DROP DATABASE database_name
38433836
*****************************************************************************/
38443837

38453838
CreateDomainStmt:
3846-
CREATE DOMAIN_P any_name opt_as Typename ColQualList opt_collate
3839+
CREATE DOMAIN_P any_name opt_as Typename ColQualList
38473840
{
38483841
CreateDomainStmt *n =makeNode(CreateDomainStmt);
38493842
n->domainname = $3;
38503843
n->typename = $5;
38513844
n->constraints = $6;
3852-
3853-
if ($7 !=NULL)
3854-
ereport(NOTICE,
3855-
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
3856-
errmsg("CREATE DOMAIN / COLLATE is not yet implemented; clause ignored")));
38573845
$$ = (Node *)n;
38583846
}
38593847
;
@@ -5463,11 +5451,6 @@ opt_charset:
54635451
|/*EMPTY*/{ $$ =NULL; }
54645452
;
54655453

5466-
opt_collate:
5467-
COLLATE ColId{ $$ = $2; }
5468-
|/*EMPTY*/{ $$ =NULL; }
5469-
;
5470-
54715454
ConstDatetime:
54725455
TIMESTAMP'(' Iconst')' opt_timezone
54735456
{
@@ -5753,15 +5736,6 @@ qual_all_Op:
57535736
a_expr:c_expr{ $$ = $1; }
57545737
| a_expr TYPECAST Typename
57555738
{ $$ =makeTypeCast($1, $3); }
5756-
| a_expr COLLATE ColId
5757-
{
5758-
FuncCall *n =makeNode(FuncCall);
5759-
n->funcname =SystemFuncName($3);
5760-
n->args =makeList1($1);
5761-
n->agg_star =FALSE;
5762-
n->agg_distinct =FALSE;
5763-
$$ = (Node *) n;
5764-
}
57655739
| a_expr AT TIME ZONE c_expr
57665740
{
57675741
FuncCall *n =makeNode(FuncCall);

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp