Commit3e00d33

committed

Have pg_dump in binary-upgrade mode properly drop user-created

extensions that might exist in the new empty cluster databases, likeplpgsql.Backpatch to 9.2.

1 parent0fc32c0 commit3e00d33Copy full SHA for 3e00d33

File tree

+10

-0

lines changed

+10

-0

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -7331,6 +7331,16 @@ dumpExtension(Archive fout, ExtensionInfo extinfo)`
`7331`	`7331`	`intn;`
`7332`	`7332`
`7333`	`7333`	`appendPQExpBuffer(q,"-- For binary upgrade, create an empty extension and insert objects into it\n");`
	`7334`	`+`
	`7335`	`+/*`
	`7336`	`+ *We unconditionally create the extension, so we must drop it if it`
	`7337`	`+ *exists. This could happen if the user deleted 'plpgsql' and then`
	`7338`	`+ *readded it, causing its oid to be greater than FirstNormalObjectId.`
	`7339`	`+ *The FirstNormalObjectId test was kept to avoid repeatedly dropping`
	`7340`	`+ *and recreating extensions like 'plpgsql'.`
	`7341`	`+ */`
	`7342`	`+appendPQExpBuffer(q,"DROP EXTENSION IF EXISTS %s;\n",qextname);`
	`7343`	`+`
`7334`	`7344`	`appendPQExpBuffer(q,`
`7335`	`7345`	`"SELECT binary_upgrade.create_empty_extension(");`
`7336`	`7346`	`appendStringLiteralAH(q,extinfo->dobj.name,fout);`

Comments

(0)