NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3db05e7

committed

Suppress compiler warning in new regex match-all detection code.

gcc 10 is smart enough to notice that control could reach this"hasmatch[depth]" assignment with depth < 0, but not smart enoughto know that that would require a badly broken NFA graph. Changethe assert() to a plain runtime test to shut it up.Per report from Andres Freund.Discussion:https://postgr.es/m/20210223173437.b3ywijygsy6q42gq@alap3.anarazel.de

1 parentd9d0762 commit3db05e7Copy full SHA for 3db05e7

File tree

1 file changed

-1

lines changed

src/backend/regex
- regc_nfa.c

1 file changed

-1

lines changed

`‎src/backend/regex/regc_nfa.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3082,8 +3082,13 @@ checkmatchall_recurse(struct nfa nfa, struct state s,`
`3082`	`3082`	`{`
`3083`	`3083`	`/* We found an all-RAINBOW path to the post state */`
`3084`	`3084`	`result= true;`
	`3085`	`+/* ... which should not be adjacent to the pre state */`
	`3086`	`+if (depth<0)`
	`3087`	`+{`
	`3088`	`+NERR(REG_ASSERT);`
	`3089`	`+return false;`
	`3090`	`+}`
`3085`	`3091`	`/* Record potential match lengths */`
`3086`		`-assert(depth >=0);`
`3087`	`3092`	`hasmatch[depth]= true;`
`3088`	`3093`	`if (foundloop)`
`3089`	`3094`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3db05e7

File tree

1 file changed

1 file changed

`‎src/backend/regex/regc_nfa.c`

0 commit comments