Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit3d8d217

Browse files
committed
ci: macos: Remove use of -Dsegsize_blocks=6
The option causes a measurable slowdown. Macos is, by far, the most expensiveplatform for CI, therefore it doesn't make sense to run such a test there.d3b111e used a small segment size for two tasks, one with autoconf, onewith meson. In hindsight that is a bit overkill, it's unlikely that the optionwould silently break. Thus don't move the -Dsegsize_blocks=6, just removeit. I did however change the autoconf test to use 6 instead of 8 blocks, aslong as we allow it, a non-power-of-two test seems like a good idea.While at it, add a comment explaining why we use a small segment size for CI.Author: Andres Freund <andres@anarazel.de>Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>Discussion:https://postgr.es/m/20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.deBackpatch: 16-, whered3b111e introduced the use of -Dsegsize_blocks=6
1 parent17ebbdf commit3d8d217

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

‎.cirrus.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,12 +331,18 @@ task:
331331
env:
332332
SANITIZER_FLAGS:-fsanitize=address
333333

334+
# Normally, the "relation segment" code basically has no coverage in our
335+
# tests, because we (quite reasonably) don't generate tables large
336+
# enough in tests. We've had plenty bugs that we didn't notice due the
337+
# code not being exercised much. Thus specify a very small segment size
338+
# here. Use a non-power-of-two segment size, given we currently allow
339+
# that.
334340
configure_script:|
335341
su postgres <<-EOF
336342
./configure \
337343
--enable-cassert --enable-debug --enable-tap-tests \
338344
--enable-nls \
339-
--with-segsize-blocks=8 \
345+
--with-segsize-blocks=6 \
340346
\
341347
${LINUX_CONFIGURE_FEATURES} \
342348
\
@@ -504,7 +510,6 @@ task:
504510
-Dextra_lib_dirs=${brewpath}/lib \
505511
-Dcassert=true \
506512
-Duuid=e2fs -Ddtrace=auto \
507-
-Dsegsize_blocks=6 \
508513
-DPG_TEST_EXTRA="$PG_TEST_EXTRA" \
509514
build
510515

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp