forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit3d37476
committed
Fix prove_installcheck when used with PGXS
Commit153e215 added the portlock directory. This is created in$ENV{top_builddir} if it is set. Under PGXS, top_builddir points intothe installation directory, which is not necessarily writable and inany case inappropriate to use by a test suite. The cause of theproblem is that the prove_installcheck target in Makefile.globalexports top_builddir, which isn't useful (since no other Perl codeactually reads it) and breaks this use case. The reason this code isthere is probably that is has been dragged around with various otherchanges, in particulara0fc813, but without a real purpose of itsown. By just removing the exporting of top_builddir inprove_installcheck, the portlock directory then ends up undertmp_check in the build directory, which is more suitable.Reviewed-by: Andrew Dunstan <andrew@dunslane.net>Discussion:https://www.postgresql.org/message-id/78d1cfa6-0065-865d-584b-cde6d8c18aff@enterprisedb.com1 parent825ebc9 commit3d37476
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
467 | | - | |
| 467 | + | |
468 | 468 | | |
469 | 469 | | |
470 | 470 | | |
| |||
0 commit comments
Comments
(0)