Commit3cb19f4

Richard Guo

committed

Fix comment about cross-checking the varnullingrels

The nullingrels match checks are not limited to debugging builds.Oversight in commit867be9c.Author: Richard GuoReviewed-by: Alvaro Herrera, Tom Lane, Robert HaasDiscussion:https://postgr.es/m/CAMbWs4_SDsdYD7DdQw7RXc3jv3axbg+RGZ7aSi9GaqX=F8hNVw@mail.gmail.com

1 parente656657 commit3cb19f4Copy full SHA for 3cb19f4

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -2775,11 +2775,11 @@ build_tlist_index_other_vars(List *tlist, int ignore_rel)`
`2775`	`2775`	`* Also ensure that varnosyn is incremented by rtoffset.`
`2776`	`2776`	`* If no match, return NULL.`
`2777`	`2777`	`*`
`2778`		`- *In debugging builds, wecross-check the varnullingrels of the subplan`
`2779`		`- *output Var based onnrm_match. Most call sites should pass NRM_EQUAL`
`2780`		`- *indicating we expectan exact match. However, there are places where`
`2781`		`- *we haven't cleanedthings up completely, and we have to settle for`
`2782`		`- *allowing subset orsuperset matches.`
	`2778`	`+ *Wecross-check the varnullingrels of the subplan output Var based on`
	`2779`	`+ * nrm_match. Most call sites should pass NRM_EQUAL indicating we expect`
	`2780`	`+ * an exact match. However, there are places where we haven't cleaned`
	`2781`	`+ * things up completely, and we have to settle for allowing subset or`
	`2782`	`+ * superset matches.`
`2783`	`2783`	`*/`
`2784`	`2784`	`staticVar*`
`2785`	`2785`	`search_indexed_tlist_for_var(Varvar,indexed_tlistitlist,`

Comments

(0)