NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3c702b3

committed

Explicitly ignore guaranteed-true result from pgstat_lock_entry().

With nowait passed as false, pgstat_lock_entry() must return trueso there's no need to check its result. Coverity seems unconvincedof this, so whack it upside the head with a (void) cast.

1 parent93fcf2d commit3c702b3Copy full SHA for 3c702b3

File tree

1 file changed

-1

lines changed

src/backend/utils/activity
- pgstat_shmem.c

1 file changed

-1

lines changed

`‎src/backend/utils/activity/pgstat_shmem.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -920,7 +920,7 @@ pgstat_reset_entry(PgStat_Kind kind, Oid dboid, Oid objoid, TimestampTz ts)`
`920`	`920`	`if (!entry_ref\|\|entry_ref->shared_entry->dropped)`
`921`	`921`	`return;`
`922`	`922`
`923`		`-pgstat_lock_entry(entry_ref, false);`
	`923`	`+(void)pgstat_lock_entry(entry_ref, false);`
`924`	`924`	`shared_stat_reset_contents(kind,entry_ref->shared_stats,ts);`
`925`	`925`	`pgstat_unlock_entry(entry_ref);`
`926`	`926`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3c702b3

File tree

1 file changed

1 file changed

`‎src/backend/utils/activity/pgstat_shmem.c`

0 commit comments