NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3bfe957

committed

Fix logic error in add_paths_to_partial_grouping_rel.

Commit3bf05e0 sometimes uses thecheapest_partial_path variable in this function to mean the cheapestone from the input rel and at other times the cheapest one from thepartially grouped rel, but it never resets it, so we can end up withbad plans, leading to "ERROR: Aggref found in non-Agg plan node".Jeevan Chalke, per a report from Andreas Joseph Krogh and a separateoff-list report from Rajkumar RaghuwanshiDiscussion:http://postgr.es/m/CAM2+6=X9kxQoL2ZqZ00E6asBt9z+rfyWbOmhXJ0+8fPAyMZ9Jg@mail.gmail.com

1 parentbe42eb9 commit3bfe957Copy full SHA for 3bfe957

File tree

1 file changed

-0

lines changed

src/backend/optimizer/plan
- planner.c

1 file changed

-0

lines changed

`‎src/backend/optimizer/plan/planner.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6339,6 +6339,9 @@ add_paths_to_partial_grouping_rel(PlannerInfo *root,`
`6339`	`6339`	`*/`
`6340`	`6340`	`generate_gather_paths(root,partially_grouped_rel, true);`
`6341`	`6341`
	`6342`	`+/* Get cheapest partial path from partially_grouped_rel */`
	`6343`	`+cheapest_partial_path=linitial(partially_grouped_rel->partial_pathlist);`
	`6344`	`+`
`6342`	`6345`	`/*`
`6343`	`6346`	`* generate_gather_paths won't consider sorting the cheapest path to match`
`6344`	`6347`	`* the group keys and then applying a Gather Merge node to the result;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3bfe957

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/planner.c`

0 commit comments