NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3adf9ce

committed

Improve check for overly-long extensible node name.

The old code is bad for two reasons. First, it has an off-by-oneerror. Second, it won't help if you aren't running with assertionsenabled. Per discussion, we want a check here in that case too.Author: KaiGai Kohei, adjusted by me.Reviewed-by: Petr JelinekDiscussion: 56E0D547.1030101@2ndquadrant.com

1 parent2da7549 commit3adf9ceCopy full SHA for 3adf9ce

File tree

1 file changed

-1

lines changed

src/backend/nodes
- extensible.c

1 file changed

-1

lines changed

`‎src/backend/nodes/extensible.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ RegisterExtensibleNodeMethods(const ExtensibleNodeMethods *methods)`
`51`	`51`	`100,&ctl,HASH_ELEM);`
`52`	`52`	`}`
`53`	`53`
`54`		`-Assert(strlen(methods->extnodename) <=EXTNODENAME_MAX_LEN);`
	`54`	`+if (strlen(methods->extnodename) >=EXTNODENAME_MAX_LEN)`
	`55`	`+elog(ERROR,"extensible node name is too long");`
`55`	`56`
`56`	`57`	`entry= (ExtensibleNodeEntry*)hash_search(extensible_node_methods,`
`57`	`58`	`methods->extnodename,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3adf9ce

File tree

1 file changed

1 file changed

`‎src/backend/nodes/extensible.c`

0 commit comments