forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit3a48005
committed
Improve code inferring length of bitmap for JITed tuple deforming.
While discussing comment improvements (see next commit) by JustinPryzby, Tom complained about a few details of the logic to infer thelength of the NULL bitmap when building the JITed tuple deformingfunction. That bitmap allows to avoid checking the tuple header'snatts, a check which often causes a pipeline stallImprovements:a) As long as missing columns aren't taken into account, we can continue to infer the length of the NULL bitmap from NOT NULL columns following it. Previously we stopped at the first missing column. It's unlikely to matter much in practice, but the alternative would have been to document why we stop.b) For robustness reasons it seems better to also check against attisdropped - RemoveAttributeById() sets attnotnull to false, but an additional check is trivial.c) Improve related commentsDiscussion:https://postgr.es/m/20637.1555957068@sss.pgh.pa.usBackpatch: -1 parente03ff73 commit3a48005
1 file changed
+20
-17
lines changedLines changed: 20 additions & 17 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
103 | 103 |
| |
104 | 104 |
| |
105 | 105 |
| |
106 |
| - | |
107 |
| - | |
| 106 | + | |
| 107 | + | |
108 | 108 |
| |
109 | 109 |
| |
110 | 110 |
| |
111 | 111 |
| |
112 | 112 |
| |
113 | 113 |
| |
114 |
| - | |
115 |
| - | |
116 |
| - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
117 | 123 |
| |
118 |
| - | |
119 |
| - | |
120 |
| - | |
121 |
| - | |
122 |
| - | |
123 |
| - | |
124 |
| - | |
125 |
| - | |
126 |
| - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
127 | 127 |
| |
128 | 128 |
| |
129 | 129 |
| |
| |||
298 | 298 |
| |
299 | 299 |
| |
300 | 300 |
| |
301 |
| - | |
302 |
| - | |
303 |
| - | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
304 | 307 |
| |
305 | 308 |
| |
306 | 309 |
| |
|
0 commit comments
Comments
(0)